OCPBUGS-61487: Add timer for Azure VIP routes reconciliation #5455
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-61487, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricky-rav The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-61487, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ricky-rav
force-pushed
the
OCPBUGS-61487
branch
from
00710a0 to
841e6c8
Compare
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
/test e2e-azure-ovn-upgrade |
|
/hold |
During systemd daemon-reload (e.g., during MCO updates), the openshift-azure-routes.path unit may miss file change events from apiserver-watcher. This leaves the azure-vips nftables table empty even when the API server is back up. Fix by adding a periodic timer that triggers reconciliation every 30 seconds as a fallback. The path unit still provides immediate response to file changes. Also wrap the service ExecStart with flock to prevent concurrent executions when both triggers fire simultaneously. Reduce logging so that we do not log when there are not routes to add. This prevents the journal from getting clogged, since the service is now triggered every 30 seconds. Signed-off-by: Riccardo Ravaioli <[email protected]>
ricky-rav
force-pushed
the
OCPBUGS-61487
branch
from
841e6c8 to
878f96a
Compare
|
/test e2e-azure-ovn-upgrade |
|
@ricky-rav: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I reduced the logs to a bare minimum, but systemd still logs to the journal every time the service is triggered: I'm still wondering what a better solution might be... |
2 participants
During systemd daemon-reload (e.g., during MCO updates), the openshift-azure-routes.path unit may miss file change events from apiserver-watcher. This leaves the azure-vips nftables table empty even when the API server is back up.
Fix by adding a periodic timer that triggers reconciliation every 30 seconds as a fallback. The path unit still provides immediate response to file changes. Also wrap the service ExecStart with flock to prevent concurrent executions when both triggers fire simultaneously.