OCPBUGS-62232: Set -fin timeouts in HAProxy config #5310
Conversation
We have a bug where misbehaved clients are exhausting the connection limits by starting a connection and abandoning it before it is even established. Setting the client-fin timeout is a recommended option to address this sort of situation. This patch also sets server-fin in the interest of symmetry and avoiding any similar issues on the server side.
openshift-ci-robot
added
jira/valid-reference
|
@cybertron: This pull request references Jira Issue OCPBUGS-62232, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@cybertron: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@cybertron: This pull request references Jira Issue OCPBUGS-62232, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by @rbbratta |
openshift-ci-robot
added
the
verified
|
@rbbratta: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/retest-required |
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
logically looks sane to me
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, rbbratta, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 4a3b43b
into
openshift:main
|
@cybertron: Jira Issue Verification Checks: Jira Issue OCPBUGS-62232 Jira Issue OCPBUGS-62232 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.21.0-0.nightly-2025-11-22-193140 |
|
/cherry-pick release-4.20 release-4.19 release-4.18 release-4.17 These are the versions requested on the bug. We can go further if needed. |
|
@cybertron: new pull request created: #5459 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release 4.19,release-4.18,release-4.17 |
|
@cybertron: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.19,release-4.18,release-4.17 |
|
@cybertron: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/jira backport release-4.19,release-4.18,release-4.17 |
|
@cybertron: Missing required branches for backport chain:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick release-4.19 release-4.18 release-4.17 |
|
@cybertron: new pull request created: #5461 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Ugh, okay, the first command actually did the right thing. I just forgot that it doesn't propose all of the patches at once. |
7 participants
We have a bug where misbehaved clients are exhausting the connection limits by starting a connection and abandoning it before it is even established. Setting the client-fin timeout is a recommended option to address this sort of situation. This patch also sets server-fin in the interest of symmetry and avoiding any similar issues on the server side.
- What I did
- How to verify it
- Description for the changelog