OLS-2101: switch to LSC app backend using magic configmap #1073
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@raptorsun: This pull request references OLS-2101 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
raptorsun
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test bundle-e2e-4-19 |
raptorsun
force-pushed
the
ols-2101
branch
2 times, most recently
from
c9090c7 to
aad9c13
Compare
| appServerReconcileFunc, err := r.getAppServerReconcileFunction(ctx) | ||
| if err != nil { | ||
| r.logger.Error(err, "Failed to get app server reconcile function") | ||
| r.updateStatusCondition(ctx, olsconfig, typeCRReconciled, false, "Failed to get app server reconcile function", err) |
There was a problem hiding this comment.
do not update status here. Its done later in the code
| // todo: implement LSC deployment generation | ||
| // | ||
| //nolint:unused // Ignore unused lint error before implementation of reconciliation functions | ||
| func (r *OLSConfigReconciler) generateLSCDeployment(ctx context.Context, cr *olsv1alpha1.OLSConfig) (*appsv1.Deployment, error) { //lint:ignore U1000 Ignore unused lint error before implementation of reconciliation functions |
There was a problem hiding this comment.
Should this be in deployment file rather than here to make it symmetric to the current one?
There was a problem hiding this comment.
let's put the LSC backend related code in a dedicated file and when we remove the old code in future, we just need to remove the old deployment file and the switch code in the main controller loop.
raptorsun
force-pushed
the
ols-2101
branch
2 times, most recently
from
b8e175b to
b779177
Compare
Signed-off-by: Haoyu Sun <[email protected]>
|
/test bundle-e2e-4-19 |
1 similar comment
|
/test bundle-e2e-4-19 |
|
@raptorsun: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Description
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing