Skip to content

Commit b00ecad

Browse files
committed
UPSTREAM: <carry>: Fail SELinuxMount check on rebase
Ensure that we remove the SELinuxMount check when the feature gate is removed from k/k. The code will fail to compile + the rebase person will find helpful comments around.
1 parent 1522eb9 commit b00ecad

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

openshift-hack/cmd/k8s-tests-ext/environment_selectors.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"fmt"
55

66
et "github.com/openshift-eng/openshift-tests-extension/pkg/extension/extensiontests"
7+
"k8s.io/kubernetes/pkg/features"
78
)
89

910
// addEnvironmentSelectors adds the environmentSelector field to appropriate specs to facilitate including or excluding
@@ -28,9 +29,10 @@ func addEnvironmentSelectors(specs et.ExtensionTestSpecs) {
2829

2930
// SELinux tests marked with [Feature:SELinuxMountReadWriteOncePodOnly] require SELinuxMount
3031
// feature gate **disabled**.
31-
// TODO(jsafrane): once SELinuxMount graduates to GA, remove the tests upstream + remove this check.
32+
// REBASE NOTE: this will intentionally fail to compile when the feature gate is removed upstream.
33+
// Just remove this check + notify the OCP storage team.
3234
specs.Select(et.NameContains("[Feature:SELinuxMountReadWriteOncePodOnly]")).
33-
Exclude(et.FeatureGateEnabled("SELinuxMount"))
35+
Exclude(et.FeatureGateEnabled(string(features.SELinuxMount)))
3436
}
3537

3638
// filterByPlatform is a helper function to do, simple, "NameContains" filtering on tests by platform

0 commit comments

Comments
 (0)