Skip to content

OCPBUGS-63015: QEMU logs are not gathered if there are pending status virt-launcher pods #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

OCPBUGS-63015: QEMU logs are not gathered if there are pending status virt-launcher pods #1164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5b6f7d
Add filtering to remove Pending pods (no logs or compute containers i…
ncaak Oct 23, 2025
13af60d
Update with QEMU gatherer last fix
ncaak Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/gathered-data.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1811,14 +1811,14 @@ None
### Released version
- 4.20.0

### Backported versions (TBD)
- 4.19.z
- 4.18.z
- 4.17.z
- 4.16.z
### Backported versions
- 4.19.12+
- 4.18.25+
- 4.17.41+
- 4.16.49+

### Changes
None
4.21 - bugfix: virt-launcher pods on 'Pending' status caused a gathering error


## SAPConfig
Expand Down
14 changes: 8 additions & 6 deletions pkg/gatherers/clusterconfig/gather_qemu_kubevirt_launcher_logs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ import (
// ### Released version
// - 4.20.0
//
// ### Backported versions (TBD)
// - 4.19.z
// - 4.18.z
// - 4.17.z
// - 4.16.z
// ### Backported versions
// - 4.19.12+
// - 4.18.25+
// - 4.17.41+
// - 4.16.49+
//
// ### Changes
// None
// 4.21 - bugfix: virt-launcher pods on 'Pending' status caused a gathering error
func (g *Gatherer) GatherQEMUKubeVirtLauncherLogs(ctx context.Context) ([]record.Record, []error) {
// Setting a fixed value for the maximum number of VMs pods
const maxVMs int = 100
Expand Down Expand Up @@ -102,10 +102,12 @@ func getQEMUArgsMessageFilter() common.LogMessagesFilter {

// getQEMUArgsContainerFilter creates a LogContainersFilter for selecting KubeVirt virt-launcher pods.
// It targets all namespaces using the label selector "kubevirt.io=virt-launcher" to identify relevant containers.
// Adding the field selector "status.phase=Running" filters out pending pods with no compute container or logs.
func getQEMUArgsContainerFilter(maxContainers int) common.LogContainersFilter {
return common.LogContainersFilter{
Namespace: metav1.NamespaceAll,
LabelSelector: "kubevirt.io=virt-launcher",
FieldSelector: "status.phase=Running",
Copy link
Contributor

@opokornyy opokornyy Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you also consider gathering data from containers that are marked as Succeeded or Failed? Or is the Running phase sufficient for us?

Copy link
Contributor Author

@ncaak ncaak Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's the work I'm checking on other ticket → OCPBUGS-63396

MaxNamespaceContainers: maxContainers,
}
}