openstack-cinder: Add --http-endpoint option to controller container

We had configured the proxy sidecar container for the driver in the
controller Deployment, but the upstream it was pointing to did not
exist. Fix this by setting the --http-endpoint option. Per the upstream
docs [1]:

  --http-endpoint <HTTP server>
    This argument is optional.

    The TCP network address where the HTTP server for providing metrics
    for diagnostics, will listen (example: `:8080`).

    The default is empty string, which means the server is disabled.

There's a bit of cleanup needed here to avoid hardcoding something which
is generated (via a loop-variable) elsewhere, but we'll do that
separately.

[1] https://github.com/kubernetes/cloud-provider-openstack/blob/release-1.32/docs/cinder-csi-plugin/using-cinder-csi-plugin.md#command-line-arguments

Signed-off-by: Stephen Finucane <[email protected]>

Author: stephenfin

assets/overlays/openstack-cinder/generated/hypershift/controller.yaml

@@ -91,6 +91,7 @@ spec:
         - --provide-controller-service=true
         - --provide-node-service=false
         - --endpoint=$(CSI_ENDPOINT)
+        - --http-endpoint=localhost:8202
         - --cloud-config=$(CLOUD_CONFIG)
         - --cluster=${CLUSTER_ID}
         - --with-topology=$(ENABLE_TOPOLOGY)

assets/overlays/openstack-cinder/generated/standalone/controller.yaml

@@ -61,6 +61,7 @@ spec:
         - --provide-controller-service=true
         - --provide-node-service=false
         - --endpoint=$(CSI_ENDPOINT)
+        - --http-endpoint=localhost:8202
         - --cloud-config=$(CLOUD_CONFIG)
         - --cluster=${CLUSTER_ID}
         - --with-topology=$(ENABLE_TOPOLOGY)

assets/overlays/openstack-cinder/patches/controller_add_driver.yaml

@@ -38,6 +38,9 @@ spec:
             - "--provide-controller-service=true"
             - "--provide-node-service=false"
             - "--endpoint=$(CSI_ENDPOINT)"
+            # this is the generated value of the LOCAL_METRICS_PORT variable
+            # we hardcode it because we don't currently support substitution
+            - "--http-endpoint=localhost:8202"
             - "--cloud-config=$(CLOUD_CONFIG)"
             - "--cluster=${CLUSTER_ID}"
             - "--with-topology=$(ENABLE_TOPOLOGY)"