Skip to content

CONSOLE-4725: follow-on fix to remove counts from Role and Binding filters #15652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2025
Merged

CONSOLE-4725: follow-on fix to remove counts from Role and Binding filters #15652

merged 3 commits into from
Nov 6, 2025

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Oct 28, 2025

Includes changes from #15651, which should merge first.

I forgot to remove the counts when we discovered including them was causing filters to re-render.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 28, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 28, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4725 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Includes changes from #15651, which should merge first.

I forgot to remove the counts when we discovered including them was causing filters to re-render.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member Author

rhamilto commented Oct 28, 2025

/hold for #15651

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2025
@openshift-ci openshift-ci bot requested review from Leo6Leo and spadgett October 28, 2025 14:12
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin component/shared Related to console-shared component/topology Related to topology labels Oct 28, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 28, 2025

/assign @logonoff

logonoff
logonoff approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto
Copy link
Member Author

rhamilto commented Oct 28, 2025

/retest

4 similar comments
@rhamilto
Copy link
Member Author

rhamilto commented Oct 29, 2025

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Oct 29, 2025

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Oct 29, 2025

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Oct 29, 2025

/retest

@jhadvig
Copy link
Member

jhadvig commented Nov 5, 2025

#15651 got merged
/hold cancel

/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Nov 5, 2025

Adding labels as this is tech debt
/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Nov 5, 2025
@rhamilto rhamilto added the plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer label Nov 5, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Nov 6, 2025

/verified by @rhamilto

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 6, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 6, 2025

@rhamilto: This PR has been marked as verified by @rhamilto.

In response to this:

/verified by @rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 30d06e7 into openshift:main Nov 6, 2025
7 of 8 checks passed
@logonoff logonoff deleted the CONSOLE-4725 branch November 6, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@spadgett spadgett Awaiting requested review from spadgett

1 more reviewer

@logonoff logonoff logonoff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@logonoff logonoff

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/knative Related to knative-plugin component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhamilto @openshift-ci-robot @jhadvig @logonoff