-
Notifications
You must be signed in to change notification settings - Fork 666
OCPBUGS-62296: Preserve path on perspective switch #15541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-62296: Preserve path on perspective switch #15541
Conversation
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
|
/cc @TheRealJon |
Signed-off-by: Kevin Cormier <[email protected]>
|
/retitle OCPBUGS-62296: Preserve path on perspective switch |
|
@KevinFCormier: This pull request references Jira Issue OCPBUGS-62296, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @logonoff |
|
/retest |
logonoff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed in dynamic plugins sync
/lgtm
|
@logonoff Assuming everying passes and this merges, would you be able to backport to older releases? I'm not familiar with the OCP z-stream process. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KevinFCormier, logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.20 |
|
@logonoff: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/jira refresh |
|
@logonoff: This pull request references Jira Issue OCPBUGS-62296, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test frontend |
|
/retest-required |
|
/test okd-scos-e2e-aws-ovn |
6 similar comments
|
/test okd-scos-e2e-aws-ovn |
|
/test okd-scos-e2e-aws-ovn |
|
/test okd-scos-e2e-aws-ovn |
|
/test okd-scos-e2e-aws-ovn |
|
/test okd-scos-e2e-aws-ovn |
|
/test okd-scos-e2e-aws-ovn |
|
@KevinFCormier: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
tested against a cluster-bot cluster, I can see path is correctly preserved in navigation but perspective switching is not happening as expected
Screen.Recording.2025-10-13.at.3.44.58.PM.mov |
|
not sure if above issue has some relation to acm version, I'm having ACM 2.14.0 though |
|
tested again with ACM 2.15 and MCE 2.10, now it looks like it's working as expected
Screen.Recording.2025-10-13.at.8.51.50.PM.mov |
|
however when I visit admin console URLs in ACM perspective, sub-path can be preserved and treated correctly, but perspective is not loaded as expected(it's still in ACM perspective) Screen.Recording.2025-10-13.at.9.01.43.PM.mov |
|
@yapei Yes, we are only starting to link pages to the ACM perspective as of 2.15.0. |
|
Thanks for confirmation @KevinFCormier |
|
@yapei: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@KevinFCormier: Jira Issue Verification Checks: Jira Issue OCPBUGS-62296 Jira Issue OCPBUGS-62296 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@logonoff: new pull request created: #15650 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Fix included in accepted release 4.21.0-0.nightly-2025-10-30-060549 |
When navigating to a dynamic plugin route directly, if the route is associated with a perspective, the path is often truncated to just what is registered in the extension. Any subpath is discarded.
This always happens if the console is not already in the target perspective, and it happens intermittently when the console is already in the target perspective.
In the examples below, I enter the URL
http://localhost:9000/multicloud/governance/policiesbut I get frequently get redirected tohttp://localhost:9000/multicloud/governancebefore the fixed code.Before
BadRedirect.mov
After
Fixed.mov