Skip to content

Conversation

@KevinFCormier
Copy link
Contributor

When navigating to a dynamic plugin route directly, if the route is associated with a perspective, the path is often truncated to just what is registered in the extension. Any subpath is discarded.

This always happens if the console is not already in the target perspective, and it happens intermittently when the console is already in the target perspective.

In the examples below, I enter the URL http://localhost:9000/multicloud/governance/policies but I get frequently get redirected to http://localhost:9000/multicloud/governance before the fixed code.

Before

BadRedirect.mov

After

Fixed.mov

@KevinFCormier
Copy link
Contributor Author

/cc @TheRealJon

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Sep 26, 2025
@logonoff
Copy link
Member

/retitle OCPBUGS-62296: Preserve path on perspective switch

@openshift-ci openshift-ci bot changed the title OCPBUGS-62296 Preserve path on perspective switch OCPBUGS-62296: Preserve path on perspective switch Sep 29, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 29, 2025
@openshift-ci-robot
Copy link
Contributor

@KevinFCormier: This pull request references Jira Issue OCPBUGS-62296, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When navigating to a dynamic plugin route directly, if the route is associated with a perspective, the path is often truncated to just what is registered in the extension. Any subpath is discarded.

This always happens if the console is not already in the target perspective, and it happens intermittently when the console is already in the target perspective.

In the examples below, I enter the URL http://localhost:9000/multicloud/governance/policies but I get frequently get redirected to http://localhost:9000/multicloud/governance before the fixed code.

Before

BadRedirect.mov

After

Fixed.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@KevinFCormier
Copy link
Contributor Author

/cc @logonoff

@KevinFCormier
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot requested a review from logonoff September 29, 2025 13:27
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed in dynamic plugins sync

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2025
@KevinFCormier
Copy link
Contributor Author

@logonoff Assuming everying passes and this merges, would you be able to backport to older releases? I'm not familiar with the OCP z-stream process.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2025
@logonoff
Copy link
Member

@logonoff Assuming everying passes and this merges, would you be able to backport to older releases? I'm not familiar with the OCP z-stream process.

/cherry-pick release-4.20

@openshift-cherrypick-robot

@logonoff: once the present PR merges, I will cherry-pick it on top of release-4.20 in a new PR and assign it to you.

In response to this:

@logonoff Assuming everying passes and this merges, would you be able to backport to older releases? I'm not familiar with the OCP z-stream process.

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@logonoff
Copy link
Member

/jira refresh
/assign @yapei

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 29, 2025
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-62296, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh
/assign @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei September 29, 2025 13:50
@KevinFCormier
Copy link
Contributor Author

/test frontend

@KevinFCormier
Copy link
Contributor Author

/retest-required

@KevinFCormier
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

6 similar comments
@KevinFCormier
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

@KevinFCormier
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

@KevinFCormier
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

@KevinFCormier
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

@KevinFCormier
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

@KevinFCormier
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@KevinFCormier: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 932456f link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yapei
Copy link
Contributor

yapei commented Oct 13, 2025

tested against a cluster-bot cluster, I can see path is correctly preserved in navigation but perspective switching is not happening as expected

  • Stay in Administrator, visit /multicloud/governance/policies URL, it goes to correct page/path, however left panel is admin perspective
  • Manually switch to Fleet Management, and visit /multicloud/governance/policies URL, it goes to correct page/path, however left panel is still admin perspective
Screen.Recording.2025-10-13.at.3.44.58.PM.mov

@yapei
Copy link
Contributor

yapei commented Oct 13, 2025

not sure if above issue has some relation to acm version, I'm having ACM 2.14.0 though

$ oc get csv -A 
NAMESPACE                              NAME                                  DISPLAY                                      VERSION          REPLACES   PHASE
multicluster-engine                    multicluster-engine.v2.9.0            multicluster engine for Kubernetes           2.9.0                       Succeeded
open-cluster-management                advanced-cluster-management.v2.14.0   Advanced Cluster Management for Kubernetes   2.14.0                      Succeeded

@yapei
Copy link
Contributor

yapei commented Oct 13, 2025

tested again with ACM 2.15 and MCE 2.10, now it looks like it's working as expected

  • In Administrator perspective, visit some urls like: /multicloud/governance/policies and /multicloud/applications/advanced sub-path can be preserved
  • In ACM perspective, stay on some page and refresh, sub-path still persisted
Screen.Recording.2025-10-13.at.8.51.50.PM.mov

@yapei
Copy link
Contributor

yapei commented Oct 13, 2025

however when I visit admin console URLs in ACM perspective, sub-path can be preserved and treated correctly, but perspective is not loaded as expected(it's still in ACM perspective)

Screen.Recording.2025-10-13.at.9.01.43.PM.mov

@KevinFCormier
Copy link
Contributor Author

@yapei Yes, we are only starting to link pages to the ACM perspective as of 2.15.0.
https://issues.redhat.com/browse/ACM-22575

@yapei
Copy link
Contributor

yapei commented Oct 28, 2025

Thanks for confirmation @KevinFCormier
/verified by @yapei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 28, 2025
@openshift-ci-robot
Copy link
Contributor

@yapei: This PR has been marked as verified by @yapei.

In response to this:

Thanks for confirmation @KevinFCormier
/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d3f9db4 into openshift:main Oct 28, 2025
7 of 8 checks passed
@openshift-ci-robot
Copy link
Contributor

@KevinFCormier: Jira Issue Verification Checks: Jira Issue OCPBUGS-62296
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-62296 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

When navigating to a dynamic plugin route directly, if the route is associated with a perspective, the path is often truncated to just what is registered in the extension. Any subpath is discarded.

This always happens if the console is not already in the target perspective, and it happens intermittently when the console is already in the target perspective.

In the examples below, I enter the URL http://localhost:9000/multicloud/governance/policies but I get frequently get redirected to http://localhost:9000/multicloud/governance before the fixed code.

Before

BadRedirect.mov

After

Fixed.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@logonoff: new pull request created: #15650

In response to this:

@logonoff Assuming everying passes and this merges, would you be able to backport to older releases? I'm not familiar with the OCP z-stream process.

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.21.0-0.nightly-2025-10-30-060549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants