Adds changes to VolumeSnapshot deletion and other changes

Signed-off-by: vbadrina <[email protected]>

Author: vbnrh

frontend/packages/console-app/console-extensions.json

@@ -411,13 +411,22 @@
         "kind": "StorageClass",
         "group": "storage.k8s.io"
       },
-<<<<<<< HEAD
-      "provider": { "$codeRef": "storageClassProvider.useStorageClassActions" }
-=======
       "provider": {
-        "$codeRef": "defaultProvider.useDefaultActionsProvider"
+        "$codeRef": "storageClassProvider.useStorageClassActions"
+      }
+    }
+  },
+  {
+    "type": "console.action/resource-provider",
+    "properties": {
+      "model": {
+        "version": "v1",
+        "kind": "VolumeSnapshot",
+        "group": "snapshot.storage.k8s.io"
+      },
+      "provider": {
+        "$codeRef": "volumeSnapshotActions.useVolumeSnapshotActions"
       }
->>>>>>> 028e543d17 (Adds CRUD action support for VolumeGroupSnapshots)
     }
   },
   {

frontend/packages/console-app/locales/en/console-app.json

@@ -233,6 +233,7 @@
   "This action is only enabled when the latest revision of the ReplicationController resource is in a failed state.": "This action is only enabled when the latest revision of the ReplicationController resource is in a failed state.",
   "Current default StorageClass": "Current default StorageClass",
   "Set as default": "Set as default",
+  "Cannot delete a snapshot that belongs to a VolumeGroupSnapshot. Delete the group instead.": "Cannot delete a snapshot that belongs to a VolumeGroupSnapshot. Delete the group instead.",
   "Access mode": "Access mode",
   "Cluster configuration": "Cluster configuration",
   "Set cluster-wide configuration for the console experience. Your changes will be autosaved and will affect after a refresh.": "Set cluster-wide configuration for the console experience. Your changes will be autosaved and will affect after a refresh.",
@@ -630,12 +631,36 @@
   "GroupSnapshot Class": "GroupSnapshot Class",
   "Persistent Volume Claim": "Persistent Volume Claim",
   "Select PVCs in the {{namespace}} namespace using label selectors to form a volume group to take VolumeGroupSnapshots.": "Select PVCs in the {{namespace}} namespace using label selectors to form a volume group to take VolumeGroupSnapshots.",
+  "Filter PVCs by Label": "Filter PVCs by Label",
+  "Expand to fix validation errors": "Expand to fix validation errors",
+  "unknown": "unknown",
+  "equals any of": "equals any of",
+  "equals": "equals",
+  "does not equal any of": "does not equal any of",
+  "does not equal": "does not equal",
+  "exists": "exists",
+  "does not exist": "does not exist",
+  "Expand to enter expression": "Expand to enter expression",
+  "Select a label": "Select a label",
+  "Operator": "Operator",
+  "Values": "Values",
+  "{{count}} selected_one": "{{count}} selected",
+  "{{count}} selected_other": "{{count}} selecteds",
+  "Select the values": "Select the values",
+  "Add label expression": "Add label expression",
+  "Source PVCs": "Source PVCs",
+  "{{count}} more PVCs _one": "{{count}} more PVCs ",
+  "{{count}} more PVCs _other": "{{count}} more PVCs s",
+  "{{count}} PVCs_one": "{{count}} PVCs",
+  "{{count}} PVCs_other": "{{count}} PVCs",
   "PVC Name": "PVC Name",
   "Storage class": "Storage class",
   "Applied filters:": "Applied filters:",
+  "No PVCs have been selected": "No PVCs have been selected",
   "Error loading PVCs": "Error loading PVCs",
   "There was an error loading the PersistentVolumeClaims. Please try again.": "There was an error loading the PersistentVolumeClaims. Please try again.",
   "Filter PVCs with label selector expressions": "Filter PVCs with label selector expressions",
+  "PVCs table": "PVCs table",
   "No PVCs have been identified for the volume group yet.": "No PVCs have been identified for the volume group yet.",
   "Use the label selector to filter and display PVCs that match your criteria. These PVCs will be used to form the volume group.": "Use the label selector to filter and display PVCs that match your criteria. These PVCs will be used to form the volume group.",
   "PVCs": "PVCs",

frontend/packages/console-app/package.json

@@ -71,7 +71,8 @@
       "consolePluginProxyDetail": "src/components/console-operator/ConsolePluginProxyDetail.tsx",
       "getConsoleOperatorConfigFlag": "src/hooks/useCanGetConsoleOperatorConfig.ts",
       "usePerspectivesAvailable": "src/components/user-preferences/perspective/usePerspectivesAvailable.ts",
-      "defaultProvider": "src/actions/providers/default-provider.ts"
+      "defaultProvider": "src/actions/providers/default-provider.ts",
+      "volumeSnapshotActions": "src/actions/providers/volume-snapshot-provider.ts"
     }
   }
 }

frontend/packages/console-app/src/actions/providers/volume-snapshot-provider.ts

@@ -0,0 +1,62 @@
+import * as React from 'react';
+import { useTranslation } from 'react-i18next';
+import { Action } from '@console/dynamic-plugin-sdk';
+import { restorePVCModal } from '@console/internal/components/modals';
+import { asAccessReview } from '@console/internal/components/utils';
+import { K8sResourceKind, referenceFor, VolumeSnapshotKind } from '@console/internal/module/k8s';
+import { useK8sModel } from '@console/shared/src/hooks/useK8sModel';
+import { getCommonResourceActions } from '../creators/common-factory';
+
+export const useVolumeSnapshotActions = (
+  volumeSnapshot: K8sResourceKind,
+): [Action[], boolean, boolean] => {
+  const [volumeSnapshotModel, inFlight] = useK8sModel(referenceFor(volumeSnapshot));
+  const { t } = useTranslation();
+  const isPartOfSnapshotGroup = React.useMemo(() => {
+    return volumeSnapshot?.metadata?.ownerReferences?.some(
+      (ref) => ref.kind === 'VolumeGroupSnapshot',
+    );
+  }, [volumeSnapshot]);
+
+  const allActions = React.useMemo(() => {
+    if (!volumeSnapshotModel || inFlight) {
+      return [];
+    }
+
+    const RestorePVC: Action = {
+      id: 'restore-pvc',
+      label: t('console-app~Restore as new PVC'),
+      cta: () =>
+        restorePVCModal({
+          kind: volumeSnapshotModel,
+          resource: volumeSnapshot as VolumeSnapshotKind,
+        }),
+      disabled: !(volumeSnapshot as VolumeSnapshotKind)?.status?.readyToUse,
+      tooltip: !(volumeSnapshot as VolumeSnapshotKind)?.status?.readyToUse
+        ? t('console-app~Volume Snapshot is not Ready')
+        : undefined,
+      accessReview: asAccessReview(volumeSnapshotModel, volumeSnapshot, 'create'),
+    };
+
+    const actions = [RestorePVC, ...getCommonResourceActions(volumeSnapshotModel, volumeSnapshot)];
+
+    if (isPartOfSnapshotGroup) {
+      return actions.map((action) => {
+        if (action.id === 'delete-resource') {
+          return {
+            ...action,
+            disabled: true,
+            disabledTooltip: t(
+              'console-app~Cannot delete a snapshot that belongs to a VolumeGroupSnapshot. Delete the group instead.',
+            ),
+          };
+        }
+        return action;
+      });
+    }
+
+    return actions;
+  }, [t, volumeSnapshotModel, volumeSnapshot, inFlight, isPartOfSnapshotGroup]);
+
+  return [allActions, !inFlight, undefined];
+};

frontend/packages/console-app/src/components/access-modes/access-mode.tsx

@@ -19,7 +19,7 @@ export const getPVCAccessModes = (resource: PersistentVolumeClaimKind, key: stri
   _.reduce(
     resource?.spec?.accessModes,
     (res, value) => {
-      const mode = getAccessModeOptions().find((accessMode) => accessMode.value === value);
+      const mode = getAccessModeOptions()?.find((accessMode) => accessMode.value === value);
       if (mode) {
         res.push(mode[key]);
       }
@@ -59,9 +59,15 @@ export const AccessModeSelector: React.FC<AccessModeSelectorProps> = (props) =>
   );
 
   const [isOpen, setIsOpen] = React.useState(false);
-  const [selected, setSelected] = React.useState<string>(
-    getAccessModeOptions().find((mode) => mode.value === pvcInitialAccessMode[0]).title,
-  );
+
+  // Fix: Add a null check and provide a default value if the mode isn't found as in case of VolumeSnapshotGroup
+  const defaultOption = getAccessModeOptions()[0] || { title: '', value: '' };
+  const foundMode =
+    pvcInitialAccessMode?.length > 0
+      ? getAccessModeOptions().find((mode) => mode.value === pvcInitialAccessMode[0])
+      : null;
+
+  const [selected, setSelected] = React.useState<string>(foundMode?.title || defaultOption.title);
 
   const onToggleClick = () => {
     setIsOpen(!isOpen);
@@ -115,11 +121,15 @@ export const AccessModeSelector: React.FC<AccessModeSelectorProps> = (props) =>
 
   React.useEffect(() => {
     // Make sure the default or already checked option button value is from any one of allowed the access mode
-    if (allowedAccessModes) {
-      if (!accessMode && allowedAccessModes.includes(pvcInitialAccessMode[0])) {
+    if (allowedAccessModes?.length) {
+      if (
+        !accessMode &&
+        pvcInitialAccessMode?.length &&
+        allowedAccessModes.includes(pvcInitialAccessMode[0])
+      ) {
         // To view the same access mode value of pvc
         changeAccessMode(pvcInitialAccessMode[0]);
-      } else if (!allowedAccessModes.includes(accessMode)) {
+      } else if (!accessMode || !allowedAccessModes.includes(accessMode)) {
         // Old access mode will be disabled
         changeAccessMode(allowedAccessModes[0]);
       }
@@ -133,7 +143,7 @@ export const AccessModeSelector: React.FC<AccessModeSelectorProps> = (props) =>
       fieldId="access-mode"
       className={className}
     >
-      {loaded && allowedAccessModes && (
+      {loaded && allowedAccessModes?.length > 0 && (
         <Select
           isOpen={isOpen}
           selected={selected}
@@ -147,12 +157,12 @@ export const AccessModeSelector: React.FC<AccessModeSelectorProps> = (props) =>
         </Select>
       )}
 
-      {allowedAccessModes && allowedAccessModes && description && (
+      {allowedAccessModes?.length > 0 && description && (
         <p className="help-block" id="access-mode-help">
           {description}
         </p>
       )}
-      {(!loaded || !allowedAccessModes) && <div className="skeleton-text" />}
+      {(!loaded || !allowedAccessModes?.length) && <div className="skeleton-text" />}
     </FormGroup>
   );
 };