Skip to content

Conversation

@dfajmon
Copy link
Contributor

@dfajmon dfajmon commented Oct 2, 2025

Move metrics to the vSphere driver from the vSphere problem detector. Before the Prometheus rules were removed with vSphere problem detector.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 2, 2025
@openshift-ci-robot
Copy link
Contributor

@dfajmon: This pull request references Jira Issue OCPBUGS-62669, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Move metrics to the vSphere driver from the vSphere problem detector. Before the Prometheus rules were removed with vSphere problem detector.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from gnufied and mandre October 2, 2025 11:07
@dfajmon
Copy link
Contributor Author

dfajmon commented Oct 2, 2025

/retest

2 similar comments
@dfajmon
Copy link
Contributor Author

dfajmon commented Oct 6, 2025

/retest

@dfajmon
Copy link
Contributor Author

dfajmon commented Oct 6, 2025

/retest

@jsafrane
Copy link
Contributor

jsafrane commented Oct 7, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025
@radeore
Copy link

radeore commented Oct 7, 2025

/retest

@jsafrane
Copy link
Contributor

jsafrane commented Oct 7, 2025

/retest-required
Azure should get fixed by openshift/release#69970 (merged ~30 minutes ago)

@radeore
Copy link

radeore commented Oct 7, 2025

/retest-required

1 similar comment
@jsafrane
Copy link
Contributor

jsafrane commented Oct 8, 2025

/retest-required

@radeore
Copy link

radeore commented Oct 8, 2025

/verified by CI test runs

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 8, 2025
@openshift-ci-robot
Copy link
Contributor

@radeore: This PR has been marked as verified by CI test runs.

In response to this:

/verified by CI test runs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 23acb42 and 2 for PR HEAD 4ff0d55 in total

@dfajmon
Copy link
Contributor Author

dfajmon commented Oct 9, 2025

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 974d984 and 1 for PR HEAD 4ff0d55 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 658ba17 and 0 for PR HEAD 4ff0d55 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 4ff0d55 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2025
@dfajmon
Copy link
Contributor Author

dfajmon commented Oct 13, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

@dfajmon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack 4ff0d55 link false /test e2e-openstack
ci/prow/e2e-openstack-parallel 4ff0d55 link false /test e2e-openstack-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfajmon
Copy link
Contributor Author

dfajmon commented Oct 13, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 70eb2fd into openshift:main Oct 13, 2025
19 of 21 checks passed
@openshift-ci-robot
Copy link
Contributor

@dfajmon: Jira Issue Verification Checks: Jira Issue OCPBUGS-62669
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-62669 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

Move metrics to the vSphere driver from the vSphere problem detector. Before the Prometheus rules were removed with vSphere problem detector.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfajmon
Copy link
Contributor Author

dfajmon commented Oct 13, 2025

/cherry-pick release-4.20

@openshift-cherrypick-robot

@dfajmon: new pull request created: #630

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants