MON-3940: Add the collection of MTV migration metrics to Telemetry #2461

bkhizgiy · 2024-09-10T08:48:12Z

Following this JIRA issue https://issues.redhat.com/browse/MON-3940

Related to this PRs for adding metrics on the MTV side:
kubev2v/forklift#916
kubev2v/forklift#932
kubev2v/forklift#978

fabiand · 2024-09-10T09:05:46Z

@simonpasquier please review

simonpasquier

You'd need to configure recording rules aggregating on the allowed labels:

status
provider
mode
target

If the metrics are emitted by a single container then you can do:

record: cluster:mtv_migrations_status_total:max
expr: max by(status, provider, mode, target) (mtv_migrations_status_total)

otherwise you should probably sum

record: cluster:mtv_migrations_status_total:sum
expr: sum by(status, provider, mode, target) (mtv_migrations_status_total)

simonpasquier · 2024-09-10T12:20:18Z

/retitle MON-3940: Add the collection of MTV migration metrics to Telemetry
/hold

until explicit approval

openshift-ci-robot · 2024-09-10T12:20:44Z

@bkhizgiy: This pull request references MON-3940 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Following this JIRA issue https://issues.redhat.com/browse/MON-3940

Related to this PRs for adding metrics on the MTV side:
kubev2v/forklift#916
kubev2v/forklift#932
kubev2v/forklift#978

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bkhizgiy · 2024-09-11T08:04:03Z

@simonpasquier Thanks for the review. Should the recording rule be part of the MTV code, or can we specify the expression in the whitelist? This metric consists only of the mentioned fields, so there aren't any labels to remove or modify.

fabiand · 2024-09-19T09:10:54Z

@simonpasquier any update?

simonpasquier · 2024-09-24T13:09:39Z

Should the recording rule be part of the MTV code, or can we specify the expression in the whitelist?

MTV code. The telemetry allow-list only references metric names (and labels).

This metric consists only of the mentioned fields, so there aren't any labels to remove or modify.

We still ask to remove the labels that are useless to keep at the Telemetry server level like instance and pod.

simonpasquier · 2024-09-24T13:10:16Z

see https://rhobs-handbook.netlify.app/products/openshiftmonitoring/telemetry.md/#configure-recording-rules

juzhao · 2024-09-25T02:54:51Z

Documentation/data-collection.md

+    #
+    # cluster:mtv_migrations_status_total is the total number of VM migrations running on the cluster,
+    # labeled with {status}, {provider}, {mode}, and {target}.
+    - '{__name__="mtv_migrations_status_total"}'


the metrics name mtv_migrations_status_total is not the same as cluster:mtv_migrations_status_total in the annotation
cluster:mtv_migrations_status_total is the total number of VM migrations running on the cluster,
maybe should be cluster:mtv_migrations_status_total:sum as @simonpasquier mentioned in #2461 (review)

Following this Jira issue https://issues.redhat.com/browse/MON-3940 Signed-off-by: Bella Khizgiyaev <[email protected]>

bkhizgiy · 2024-11-05T14:30:51Z

Following the comments, I’ve added a new recording rule for MTV in this PR.
I’ve also updated this PR with the new rule name accordingly.
Please let me know if anything else is needed.

Following the request of adding recording rule in openshift/cluster-monitoring-operator#2461 Signed-off-by: Bella Khizgiyaev <[email protected]>

fabiand · 2024-11-29T09:24:26Z

kubev2v/forklift#1172 got merged - what is needed to move this PR forward?

openshift-merge-robot · 2024-11-29T09:26:02Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sradco · 2024-12-09T07:02:46Z

Hi @bkhizgiy, looks like the PR needs a rebase. Is there anything else keeping thos PR from getting merged?

openshift-ci · 2025-01-17T16:50:09Z

@bkhizgiy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/rules	`9dd664b`	link	true	`/test rules`
ci/prow/okd-scos-images	`9dd664b`	link	true	`/test okd-scos-images`
ci/prow/shellcheck	`9dd664b`	link	true	`/test shellcheck`
ci/prow/unit	`9dd664b`	link	true	`/test unit`
ci/prow/generate	`9dd664b`	link	true	`/test generate`
ci/prow/e2e-aws-ovn-upgrade	`9dd664b`	link	true	`/test e2e-aws-ovn-upgrade`
ci/prow/jsonnet-fmt	`9dd664b`	link	true	`/test jsonnet-fmt`
ci/prow/e2e-aws-ovn	`9dd664b`	link	true	`/test e2e-aws-ovn`
ci/prow/images	`9dd664b`	link	true	`/test images`
ci/prow/golangci-lint	`9dd664b`	link	true	`/test golangci-lint`
ci/prow/vendor	`9dd664b`	link	true	`/test vendor`
ci/prow/verify	`9dd664b`	link	true	`/test verify`
ci/prow/e2e-agnostic-operator	`9dd664b`	link	true	`/test e2e-agnostic-operator`
ci/prow/e2e-aws-ovn-techpreview	`9dd664b`	link	true	`/test e2e-aws-ovn-techpreview`
ci/prow/e2e-hypershift-conformance	`9dd664b`	link	true	`/test e2e-hypershift-conformance`
ci/prow/go-fmt	`9dd664b`	link	true	`/test go-fmt`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2025-04-18T01:00:39Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

fabiand · 2025-05-15T09:36:17Z

Folks. I am really not sure what can be done to get this merged.

openshift-bot · 2025-06-15T00:30:51Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2025-07-15T08:01:01Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2025-07-15T08:01:44Z

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fabiand · 2025-10-13T08:12:09Z

/reopen

openshift-ci · 2025-10-13T08:12:25Z

@fabiand: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-10-13T08:12:26Z

@bkhizgiy: This pull request references MON-3940 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Following this JIRA issue https://issues.redhat.com/browse/MON-3940

Related to this PRs for adding metrics on the MTV side:
kubev2v/forklift#916
kubev2v/forklift#932
kubev2v/forklift#978

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-10-13T08:13:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bkhizgiy
Once this PR has been reviewed and has the lgtm label, please assign simonpasquier for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Continuation of https://issues.redhat.com/browse/MON-3940. Previous outdated PR: openshift#2461 As the previous PR was stale and the person who created the PR is not longer working on it, I recreated the PR. Ref: https://issues.redhat.com/browse/MTV-1370 Signed-off-by: Stefan Olenocin <[email protected]>

solenoci · 2025-11-11T14:38:46Z

I recreated the PR here: #2743 as Bella is no longer responsible for it. Feel free to close if you don't need it.

Continuation of https://issues.redhat.com/browse/MON-3940. Previous outdated PR: openshift#2461 As the previous PR was stale and the person who created the PR is not longer working on it, I recreated the PR. Ref: https://issues.redhat.com/browse/MTV-1370 Signed-off-by: Stefan Olenocin <[email protected]>

openshift-ci bot requested review from jan--f and marioferh September 10, 2024 08:50

simonpasquier reviewed Sep 10, 2024

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2024

openshift-ci bot changed the title ~~Add the collection of MTV migration metrics to Telemetry~~ MON-3940: Add the collection of MTV migration metrics to Telemetry Sep 10, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 10, 2024

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2024

juzhao reviewed Sep 25, 2024

View reviewed changes

Add collection of MTV migration metrics to Telemetry

9dd664b

Following this Jira issue https://issues.redhat.com/browse/MON-3940 Signed-off-by: Bella Khizgiyaev <[email protected]>

bkhizgiy mentioned this pull request Nov 5, 2024

Add recording rule to collect migrations data to telemetry. kubev2v/forklift#1172

Merged

bkhizgiy force-pushed the metricsMTV branch from ddd0170 to 9dd664b Compare November 5, 2024 14:27

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2024

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2024

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2025

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 15, 2025

openshift-ci bot closed this Jul 15, 2025

openshift-ci bot reopened this Oct 13, 2025

solenoci mentioned this pull request Nov 11, 2025

MON-3940: Add the collection of MTV migration metrics to Telemetry #2743

Merged

2 tasks

MON-3940: Add the collection of MTV migration metrics to Telemetry #2461

Are you sure you want to change the base?

MON-3940: Add the collection of MTV migration metrics to Telemetry #2461

Uh oh!

Conversation

bkhizgiy commented Sep 10, 2024

Uh oh!

fabiand commented Sep 10, 2024

Uh oh!

simonpasquier left a comment

Choose a reason for hiding this comment

Uh oh!

simonpasquier commented Sep 10, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 10, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkhizgiy commented Sep 11, 2024

Uh oh!

fabiand commented Sep 19, 2024

Uh oh!

simonpasquier commented Sep 24, 2024

Uh oh!

simonpasquier commented Sep 24, 2024

Uh oh!

juzhao Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bkhizgiy commented Nov 5, 2024

Uh oh!

fabiand commented Nov 29, 2024

Uh oh!

openshift-merge-robot commented Nov 29, 2024

Uh oh!

sradco commented Dec 9, 2024

Uh oh!

openshift-ci bot commented Jan 17, 2025

Uh oh!

openshift-bot commented Apr 18, 2025

Uh oh!

fabiand commented May 15, 2025

Uh oh!

openshift-bot commented Jun 15, 2025

Uh oh!

openshift-bot commented Jul 15, 2025

Uh oh!

openshift-ci bot commented Jul 15, 2025

Uh oh!

fabiand commented Oct 13, 2025

Uh oh!

openshift-ci bot commented Oct 13, 2025

Uh oh!

openshift-ci-robot commented Oct 13, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Oct 13, 2025

Uh oh!

solenoci commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

simonpasquier commented Sep 10, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Sep 10, 2024 •

edited by openshift-ci bot

Loading

juzhao Sep 25, 2024 •

edited

Loading

openshift-ci-robot commented Oct 13, 2025 •

edited by openshift-ci bot

Loading

solenoci commented Nov 11, 2025 •

edited

Loading