Skip to content

Commit f15addc

Browse files
Merge pull request #2409 from slashpai/remove-adapter
MON-3900: Remove prometheus-adapter code
2 parents 58d43fa + 005e090 commit f15addc

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+25
-1898
lines changed

.github/ISSUE_TEMPLATE/release.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ about: Create release checklist
1616
- [ ] update downstream backport of [openshift/prometheus-operator](https://github.com/openshift/prometheus-operator)
1717
- [ ] update downstream backport of [openshift/kube-state-metrics](https://github.com/openshift/kube-state-metrics)
1818
- [ ] update downstream backport of [openshift/kube-rbac-proxy](https://github.com/openshift/kube-rbac-proxy)
19-
- [ ] update downstream backport of [openshift/k8s-prometheus-adapter](https://github.com/openshift/k8s-prometheus-adapter)
19+
- [ ] update downstream backport of [openshift/kubernetes-metrics-server](https://github.com/openshift/kubernetes-metrics-server)
2020

2121
## Jsonnet dependencies
2222

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Note: This CHANGELOG is only for the monitoring team to track all monitoring related changes. Please see OpenShift release notes for official changes.
22

3+
## 4.17
4+
5+
- [#2409](https://github.com/openshift/cluster-monitoring-operator/issues/2409) Remove prometheus-adapter code from CMO
6+
37
## 4.16
48

59
- [#2302](https://github.com/openshift/cluster-monitoring-operator/issues/2302) Enable feature `extra-scrape-metrics` in Prometheus user-workload

Documentation/api.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ The `ClusterMonitoringConfiguration` resource defines settings that customize th
128128
| -------- | ---- | ----------- |
129129
| alertmanagerMain | *[AlertmanagerMainConfig](#alertmanagermainconfig) | `AlertmanagerMainConfig` defines settings for the Alertmanager component in the `openshift-monitoring` namespace. |
130130
| enableUserWorkload | *bool | `UserWorkloadEnabled` is a Boolean flag that enables monitoring for user-defined projects. |
131-
| k8sPrometheusAdapter | *[K8sPrometheusAdapter](#k8sprometheusadapter) | `K8sPrometheusAdapter` defines settings for the Prometheus Adapter component. |
132131
| metricsServer | *[MetricsServerConfig](#metricsserverconfig) | `MetricsServer` defines settings for the MetricsServer component. |
133132
| kubeStateMetrics | *[KubeStateMetricsConfig](#kubestatemetricsconfig) | `KubeStateMetricsConfig` defines settings for the `kube-state-metrics` agent. |
134133
| prometheusK8s | *[PrometheusK8sConfig](#prometheusk8sconfig) | `PrometheusK8sConfig` defines settings for the Prometheus component. |
@@ -146,10 +145,7 @@ The `ClusterMonitoringConfiguration` resource defines settings that customize th
146145

147146
#### Description
148147

149-
The `K8sPrometheusAdapter` resource defines settings for the Prometheus Adapter component. This is deprecated and will be removed in a future version.
150-
151-
152-
<em>appears in: [ClusterMonitoringConfiguration](#clustermonitoringconfiguration)</em>
148+
The `K8sPrometheusAdapter` resource defines settings for the Prometheus Adapter component. This is deprecated config, setting this has no effect and will be removed in a future version.
153149

154150
| Property | Type | Description |
155151
| -------- | ---- | ----------- |

Documentation/deps-versions.md

Lines changed: 11 additions & 11 deletions
Large diffs are not rendered by default.

Documentation/openshiftdocs/modules/clustermonitoringconfiguration.adoc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ The `ClusterMonitoringConfiguration` resource defines settings that customize th
1919

2020
|enableUserWorkload|*bool|`UserWorkloadEnabled` is a Boolean flag that enables monitoring for user-defined projects.
2121

22-
|k8sPrometheusAdapter|*link:k8sprometheusadapter.adoc[K8sPrometheusAdapter]|`K8sPrometheusAdapter` defines settings for the Prometheus Adapter component.
23-
2422
|metricsServer|*link:metricsserverconfig.adoc[MetricsServerConfig]|`MetricsServer` defines settings for the MetricsServer component.
2523

2624
|kubeStateMetrics|*link:kubestatemetricsconfig.adoc[KubeStateMetricsConfig]|`KubeStateMetricsConfig` defines settings for the `kube-state-metrics` agent.

Documentation/openshiftdocs/modules/k8sprometheusadapter.adoc

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,9 @@
99

1010
=== Description
1111

12-
The `K8sPrometheusAdapter` resource defines settings for the Prometheus Adapter component. This is deprecated and will be removed in a future version.
12+
The `K8sPrometheusAdapter` resource defines settings for the Prometheus Adapter component. This is deprecated config, setting this has no effect and will be removed in a future version.
1313

1414

15-
16-
Appears in: link:clustermonitoringconfiguration.adoc[ClusterMonitoringConfiguration]
17-
1815
[options="header"]
1916
|===
2017
| Property | Type | Description

Documentation/resources.adoc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,6 @@ Expose openshift-state-metrics `/metrics` endpoints within the cluster on the fo
101101
* Port 8443 provides access to the OpenShift resource metrics. This port is for internal use, and no other usage is guaranteed.
102102
* Port 9443 provides access to the internal `openshift-state-metrics` metrics. This port is for internal use, and no other usage is guaranteed.
103103

104-
=== openshift-monitoring/prometheus-adapter
105-
106-
Expose the `prometheus-adapter` web server on port 443. This port is for internal use, and no other usage is guaranteed.
107-
108104
=== openshift-monitoring/prometheus-k8s
109105

110106
Expose the Prometheus web server within the cluster on the following ports:

Documentation/resources.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,6 @@ Expose openshift-state-metrics `/metrics` endpoints within the cluster on the fo
8282
* Port 8443 provides access to the OpenShift resource metrics. This port is for internal use, and no other usage is guaranteed.
8383
* Port 9443 provides access to the internal `openshift-state-metrics` metrics. This port is for internal use, and no other usage is guaranteed.
8484

85-
### openshift-monitoring/prometheus-adapter
86-
87-
Expose the `prometheus-adapter` web server on port 443. This port is for internal use, and no other usage is guaranteed.
88-
8985
### openshift-monitoring/prometheus-k8s
9086

9187
Expose the Prometheus web server within the cluster on the following ports:

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ It contains the following components:
99
* [Alertmanager](https://github.com/prometheus/alertmanager) cluster for cluster and application level alerting
1010
* [kube-state-metrics](https://github.com/kubernetes/kube-state-metrics)
1111
* [node_exporter](https://github.com/prometheus/node_exporter)
12-
* [prometheus-adapter](https://github.com/kubernetes-sigs/prometheus-adapter)
13-
* [kubernetes-metrics-server](https://github.com/openshift/kubernetes-metrics-server) only on TechPreviewNoUpgrade cluster
12+
* [kubernetes-metrics-server](https://github.com/openshift/kubernetes-metrics-server)
1413

1514
The deployed Prometheus instance (`prometheus-k8s`) is responsible for monitoring and alerting on cluster and OpenShift components; it should not be extended to monitor user applications. Users interested in leveraging Prometheus for application monitoring on OpenShift should consider enabling [User Workload Monitoring](https://docs.openshift.com/container-platform/4.5/monitoring/monitoring-your-own-services.html) to easily setup new Prometheus instances to monitor and alert on their applications.
1615

assets/prometheus-adapter/api-service.yaml

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)