Skip to content

Commit 61248d9

Browse files
Merge pull request #2235 from bertinatto/add-cbor-feature-gate
CNTRLPLANE-5: Add CBOR feature gate
2 parents c71c7b2 + 1780521 commit 61248d9

8 files changed

+81
-0
lines changed

features.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@
2727
| AzureDualStackInstall| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
2828
| AzureMultiDisk| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
2929
| BootcNodeManagement| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
30+
| CBORServingAndStorage| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
31+
| ClientsAllowCBOR| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
32+
| ClientsPreferCBOR| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
3033
| ClusterAPIInstallIBMCloud| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
3134
| ClusterMonitoringConfig| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
3235
| ClusterVersionOperatorConfiguration| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |

features/features.go

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -881,4 +881,28 @@ var (
881881
enhancementPR("https://github.com/openshift/enhancements/pull/1806").
882882
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
883883
mustRegister()
884+
885+
FeatureCBORServingAndStorage = newFeatureGate("CBORServingAndStorage").
886+
reportProblemsToJiraComponent("kube-apiserver").
887+
contactPerson("benluddy").
888+
productScope(kubernetes).
889+
enhancementPR("https://github.com/kubernetes/enhancements/issues/4222").
890+
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
891+
mustRegister()
892+
893+
FeatureCBORClientsAllowCBOR = newFeatureGate("ClientsAllowCBOR").
894+
reportProblemsToJiraComponent("kube-apiserver").
895+
contactPerson("benluddy").
896+
productScope(kubernetes).
897+
enhancementPR("https://github.com/kubernetes/enhancements/issues/4222").
898+
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
899+
mustRegister()
900+
901+
FeatureClientsPreferCBOR = newFeatureGate("ClientsPreferCBOR").
902+
reportProblemsToJiraComponent("kube-apiserver").
903+
contactPerson("benluddy").
904+
productScope(kubernetes).
905+
enhancementPR("https://github.com/kubernetes/enhancements/issues/4222").
906+
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
907+
mustRegister()
884908
)

payload-manifests/featuregates/featureGate-Hypershift-Default.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,15 @@
4949
{
5050
"name": "BootcNodeManagement"
5151
},
52+
{
53+
"name": "CBORServingAndStorage"
54+
},
55+
{
56+
"name": "ClientsAllowCBOR"
57+
},
58+
{
59+
"name": "ClientsPreferCBOR"
60+
},
5261
{
5362
"name": "ClusterAPIInstall"
5463
},

payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,18 @@
101101
{
102102
"name": "BuildCSIVolumes"
103103
},
104+
{
105+
"name": "CBORServingAndStorage"
106+
},
104107
{
105108
"name": "CPMSMachineNamePrefix"
106109
},
110+
{
111+
"name": "ClientsAllowCBOR"
112+
},
113+
{
114+
"name": "ClientsPreferCBOR"
115+
},
107116
{
108117
"name": "ClusterAPIInstallIBMCloud"
109118
},

payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,18 @@
113113
{
114114
"name": "BuildCSIVolumes"
115115
},
116+
{
117+
"name": "CBORServingAndStorage"
118+
},
116119
{
117120
"name": "CPMSMachineNamePrefix"
118121
},
122+
{
123+
"name": "ClientsAllowCBOR"
124+
},
125+
{
126+
"name": "ClientsPreferCBOR"
127+
},
119128
{
120129
"name": "ClusterAPIInstallIBMCloud"
121130
},

payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,15 @@
4949
{
5050
"name": "BootcNodeManagement"
5151
},
52+
{
53+
"name": "CBORServingAndStorage"
54+
},
55+
{
56+
"name": "ClientsAllowCBOR"
57+
},
58+
{
59+
"name": "ClientsPreferCBOR"
60+
},
5261
{
5362
"name": "ClusterAPIInstall"
5463
},

payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,18 @@
8383
{
8484
"name": "BuildCSIVolumes"
8585
},
86+
{
87+
"name": "CBORServingAndStorage"
88+
},
8689
{
8790
"name": "CPMSMachineNamePrefix"
8891
},
92+
{
93+
"name": "ClientsAllowCBOR"
94+
},
95+
{
96+
"name": "ClientsPreferCBOR"
97+
},
8998
{
9099
"name": "ClusterAPIInstallIBMCloud"
91100
},

payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,18 @@
9595
{
9696
"name": "BuildCSIVolumes"
9797
},
98+
{
99+
"name": "CBORServingAndStorage"
100+
},
98101
{
99102
"name": "CPMSMachineNamePrefix"
100103
},
104+
{
105+
"name": "ClientsAllowCBOR"
106+
},
107+
{
108+
"name": "ClientsPreferCBOR"
109+
},
101110
{
102111
"name": "ClusterAPIInstallIBMCloud"
103112
},

0 commit comments

Comments
 (0)