Check for empty pull-secrets

Author: cardil

hack/lib/catalogsource.bash

@@ -116,7 +116,10 @@ EOF
   # to be linked with the right pull secret before creating the Pod. This is to prevent race conditions.
   timeout 120 "[[ \$(oc -n $OLM_NAMESPACE get pods -l olm.catalogSource=serverless-operator --no-headers | wc -l) != 1 ]]"
   index_pod=$(oc -n "$OLM_NAMESPACE" get pods -l olm.catalogSource=serverless-operator -oname)
-  if ! oc -n "$OLM_NAMESPACE" get "$index_pod" -ojsonpath='{.spec.imagePullSecrets}' | grep dockercfg &>/dev/null; then
+  # shellcheck disable=SC2266
+  if oc -n "$OLM_NAMESPACE" get "$index_pod" -ojsonpath='{.spec.imagePullSecrets}' | [ -t 0 ]; then
+    # pull secrets are present, see: https://unix.stackexchange.com/a/388462
+    # wait until they have dockercfg one
     timeout 120 "[[ \$(oc -n $OLM_NAMESPACE get sa serverless-operator -ojsonpath='{.imagePullSecrets}' | grep -c dockercfg) == 0 ]]"
     oc -n "$OLM_NAMESPACE" delete pods -l olm.catalogSource=serverless-operator
   fi