Skip to content

Commit b92e13d

Browse files
committed
Add TODO on add agent memory type check
Signed-off-by: Sicheng Song <[email protected]>
1 parent 7eadbf5 commit b92e13d

File tree

1 file changed

+4
-0
lines changed
  • ml-algorithms/src/main/java/org/opensearch/ml/engine/algorithms/agent

1 file changed

+4
-0
lines changed

ml-algorithms/src/main/java/org/opensearch/ml/engine/algorithms/agent/AgentUtils.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1101,6 +1101,10 @@ public static Map<String, Object> createMemoryParams(
11011101
}
11021102

11031103
// Check if parameters are wrapped in memory_configuration
1104+
// In current implementation, agent memory processing method will be overridden to remote agentic memory
1105+
// if the agent receive the memory config field, no matter what its previous memory type is.
1106+
// In long run, memory configuration should only be expected for remote agentic memory type.
1107+
// TODO: Add a memory type check to restrict memory config to remote agentic memory only
11041108
String memoryConfigStr = requestParameters.get("memory_configuration");
11051109
if (!Strings.isNullOrEmpty(memoryConfigStr)) {
11061110
// Parse the memory_configuration JSON

0 commit comments

Comments
 (0)