CB change need hasFailure pre-check

it's not idempotent and may be called by non-synchronized thread like tryExecuteNext

Signed-off-by: bowenlan-amzn <[email protected]>

Author: bowenlan-amzn

server/src/main/java/org/opensearch/action/search/QueryPhaseResultConsumer.java

@@ -342,13 +342,19 @@ private void sortBuffer() {
         }
 
         private synchronized long addWithoutBreaking(long size) {
+            if (hasFailure()) {
+                return circuitBreakerBytes;
+            }
             circuitBreaker.addWithoutBreaking(size);
             circuitBreakerBytes += size;
             maxAggsCurrentBufferSize = Math.max(maxAggsCurrentBufferSize, circuitBreakerBytes);
             return circuitBreakerBytes;
         }
 
         private synchronized long addEstimateAndMaybeBreak(long estimatedSize) {
+            if (hasFailure()) {
+                return circuitBreakerBytes;
+            }
             circuitBreaker.addEstimateBytesAndMaybeBreak(estimatedSize, "<reduce_aggs>");
             circuitBreakerBytes += estimatedSize;
             maxAggsCurrentBufferSize = Math.max(maxAggsCurrentBufferSize, circuitBreakerBytes);