From ebf14f9d5715d719536da66911a15cf45bdf69c9 Mon Sep 17 00:00:00 2001 From: Tim te Beek Date: Fri, 29 Aug 2025 11:42:01 +0200 Subject: [PATCH 1/2] Compare `JavaType.Method.name` before `declaringType` in `equals(Object)` --- .../src/main/java/org/openrewrite/java/tree/JavaType.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rewrite-java/src/main/java/org/openrewrite/java/tree/JavaType.java b/rewrite-java/src/main/java/org/openrewrite/java/tree/JavaType.java index f113a6ec40..6b50ba6474 100644 --- a/rewrite-java/src/main/java/org/openrewrite/java/tree/JavaType.java +++ b/rewrite-java/src/main/java/org/openrewrite/java/tree/JavaType.java @@ -1565,8 +1565,8 @@ public boolean equals(Object o) { if (this == o) return true; if (o == null || getClass() != o.getClass()) return false; Method method = (Method) o; - return Objects.equals(declaringType, method.declaringType) && - name.equals(method.name) && + return Objects.equals(name, method.name) && + Objects.equals(declaringType, method.declaringType) && Objects.equals(returnType, method.returnType) && Arrays.equals(parameterTypes, method.parameterTypes); } From 932fa3a1f20afa4fb26831333398d5c7b7a283ab Mon Sep 17 00:00:00 2001 From: Tim te Beek Date: Fri, 29 Aug 2025 11:50:26 +0200 Subject: [PATCH 2/2] Comment out RemoveSystemOutPrintln --- rewrite.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rewrite.yml b/rewrite.yml index 2951f0de21..9566c18ee5 100644 --- a/rewrite.yml +++ b/rewrite.yml @@ -68,7 +68,7 @@ recipeList: - org.openrewrite.java.recipes.UseTreeRandomId - org.openrewrite.java.recipes.migrate.RemoveTraitsUsageRecipes - org.openrewrite.staticanalysis.NeedBraces - - org.openrewrite.staticanalysis.RemoveSystemOutPrintln +# - org.openrewrite.staticanalysis.RemoveSystemOutPrintln # - org.openrewrite.java.RemoveAnnotation: # annotationPattern: '@org.openrewrite.NlsRewrite.DisplayName' # - org.openrewrite.java.RemoveAnnotation: