XML parser parses comments inside doctype subset into Xml.Ident

[knutwannheden]

Given an XML document like the following:

  <?xml version="1.0" encoding="iso-8859-1" standalone="no"?>
  <!DOCTYPE xsl:stylesheet [
  <!-- EXSLT-Math -->
  <!ENTITY foons "https://www.foo.org/bar">
  ]>
  <xsl:stylesheet version="1.0"/>

the parser parses the comment into an Xml.Ident element rather than creating an Xml.Comment:

rewrite/rewrite-xml/src/main/java/org/openrewrite/xml/internal/XmlParserVisitor.java

Lines 334 to 338 in b6f178b

	for (int i = 0; i < children.size(); i++) {
	ParserRuleContext element = (ParserRuleContext) children.get(i);
	// Markup declarations are not fully implemented.
	// n.getText() includes element subsets.
	Xml.Ident ident = convert(element, (n, p) -> new Xml.Ident(randomId(), p, Markers.EMPTY, n.getText()));

.

The name of the created Xml.Ident is <!-- EXSLT-Math --> which then can cause recipes to fail processing this.