Skip to content

Commit 5906014

Browse files
committed
FindMissingTypes: Fix some null warnings
1 parent bfaa97a commit 5906014

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

Diff for: rewrite-java/src/main/java/org/openrewrite/java/search/FindMissingTypes.java

+10-6
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,15 @@ public <M extends Marker> M visitMarker(Marker marker, List<MissingTypeResult> m
7474
.map(t -> t.getClass().getSimpleName())
7575
.collect(Collectors.joining("->"));
7676
J j = getCursor().firstEnclosing(J.class);
77-
String printedTree;
78-
if (getCursor().firstEnclosing(JavaSourceFile.class) != null) {
79-
printedTree = j != null ? j.printTrimmed(new InMemoryExecutionContext(), getCursor().getParentOrThrow()) : "";
80-
} else {
81-
printedTree = String.valueOf(j);
77+
if (j != null) {
78+
String printedTree;
79+
if (getCursor().firstEnclosing(JavaSourceFile.class) != null) {
80+
printedTree = j.printTrimmed(new InMemoryExecutionContext(), getCursor().getParentOrThrow());
81+
} else {
82+
printedTree = String.valueOf(j);
83+
}
84+
missingTypeResults.add(new MissingTypeResult(message, path, printedTree, j));
8285
}
83-
missingTypeResults.add(new MissingTypeResult(message, path, printedTree, j));
8486
}
8587
return super.visitMarker(marker, missingTypeResults);
8688
}
@@ -92,7 +94,9 @@ public <M extends Marker> M visitMarker(Marker marker, List<MissingTypeResult> m
9294
@Getter
9395
@AllArgsConstructor
9496
public static class MissingTypeResult {
97+
@Nullable
9598
String message;
99+
96100
String path;
97101
String printedTree;
98102
J j;

0 commit comments

Comments
 (0)