-
Notifications
You must be signed in to change notification settings - Fork 85
ParameterizedRunnerToParameterized update to account for test class inheritance #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This requires openrewrite/rewrite#150 |
This has been kicking around since March and we haven't prioritized it. Once we implement openrewrite/rewrite#150 we can revisit issues like this. |
Re-Opening given that 7.17.0 has better JavaType information |
The current recipe implementation replaces the constructor with the initialize method. Applying this logic to the |
I've implemented a test case to reproduce in ParameterizedRunnerToParameterizedTest and implemented a first version of the required changes in the test methods. Currently the migration of the base class is missing. |
Discovered while applying
JUnit4To5Migration
on AntlrFor tests classes that inherit from a superclass and have a constructor which invokes the superclass constructor:
before:
after:
e.g. Antlr4-TestPerformance
The text was updated successfully, but these errors were encountered: