Skip to content

BeanMethodsNotPublic should not change visibility of overrided methods #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
murdos opened this issue May 26, 2021 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@murdos
Copy link

murdos commented May 26, 2021

Otherwise it leads to compilation failures.

Example:

public interface AbstractConfiguration {
    MyBean mybean();
}

@Configuration
public class ConcreteConfiguration implements AbstractConfiguration {

    @Bean
    @Override
    public MyBean mybean() {
        return new MyBean();
    }

}
@sambsnyd
Copy link
Member

Thanks for reporting this issue.
Fixing this requires on openrewrite/rewrite#150
In the meantime we should remove it from the best practices recipe

@sambsnyd sambsnyd added the bug Something isn't working label May 26, 2021
@sambsnyd sambsnyd self-assigned this Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants