Merge pull request #1153 from rwf-rr/fix-tritems-in-track-viewer

Fix TrItems in track viewer (events were over-writing mileposts)

Author: sweiland-openrails

Source/Contrib/TrackViewer/Drawing/DrawTrackDB.cs

@@ -107,37 +107,14 @@ public RouteData(string routePath, MessageDelegate messageDelegate)
                 //sigcfgFile = null; // default initialization
             }
 
-            // read the activity location events and store them in the TrackDB.TrItemTable
+            // read the activity location events and add them to the TrackDB.TrItemTable
 
             ActivityNames.Clear();
             var directory = System.IO.Path.Combine(routePath, "ACTIVITIES");
             if (System.IO.Directory.Exists(directory))
             {
-                // counting
-                int cnt = 0;
-
-                foreach (var file in Directory.GetFiles(directory, "*.act"))
-                {
-                    try
-                    {
-                        var activityFile = new ActivityFile(file);
-                        Events events = activityFile.Tr_Activity.Tr_Activity_File.Events;
-                        if (events != null)
-                        {
-                            for (int i = 0; i < events.EventList.Count; i++)
-                            {
-                                if (events.EventList[i].GetType() == typeof(EventCategoryLocation))
-                                {
-                                    cnt++;
-                                }
-                            }
-                        }
-                    }
-                    catch { }
-                }
-
-                // adding
-                uint index = 0;
+                int index = TrackDB.TrItemTable.Length;
+                List<TrItem> eventItems = new List<TrItem>();
                 foreach (var file in Directory.GetFiles(directory, "*.act"))
                 {
                     try
@@ -157,8 +134,8 @@ public RouteData(string routePath, MessageDelegate messageDelegate)
                                         eventCategoryLocation.Outcomes.DisplayMessage,
                                         eventCategoryLocation.TileX, eventCategoryLocation.TileZ,
                                         eventCategoryLocation.X, 0, eventCategoryLocation.Z,
-                                        index);
-                                    TrackDB.TrItemTable[index] = eventItem;
+                                        (uint)index);
+                                    eventItems.Add(eventItem);
                                     index++;
                                     found = true;
                                 }
@@ -168,9 +145,18 @@ public RouteData(string routePath, MessageDelegate messageDelegate)
                             ActivityNames.Add(activityFile.Tr_Activity.Tr_Activity_Header.Name);
                         }
                     }
-                    catch { }
+                    catch { /* just ignore activity files with problems */ }
                 }
 
+                // extend the track items array and append the event items
+                if (eventItems.Count > 0)
+                {
+                    int oldSize = TrackDB.TrItemTable.Length;
+                    Array.Resize<TrItem>(ref TrackDB.TrItemTable, index);
+                    int newSize = TrackDB.TrItemTable.Length;
+                    int eventSize = eventItems.Count;
+                    for (int toIdx = oldSize, fromIdx = 0; toIdx < newSize && fromIdx < eventSize; toIdx++, fromIdx++) { TrackDB.TrItemTable[toIdx] = eventItems[fromIdx]; }
+                }
             }
         }
 

Source/Contrib/TrackViewer/Editing/Charts/DrawPathChart.cs

@@ -54,6 +54,9 @@ public class DrawPathChart
 
         private bool ChartWindowIsOpen { get { return chartWindow.Visibility == Visibility.Visible; } }
 
+        // save window title from properies, so that the window's title can be changed when the selected path is changed
+        private readonly String WindowTitle;
+
         /// <summary>
         /// Constructor
         /// </summary>
@@ -64,6 +67,7 @@ public DrawPathChart()
                 OnJsonSaveClick = OnJsonSave
             };
             TrackViewer.Localize(chartWindow);
+            if (WindowTitle == null) WindowTitle = chartWindow.Title;
         }
 
         /// <summary>
@@ -113,6 +117,7 @@ public void Open()
             {   // it path is broken, OnPathChanged performed a close
                 return;
             }
+            chartWindow.Title = String.Format("{0}: {1}", WindowTitle, pathEditor.CurrentTrainPath.PathName);
             chartWindow.Show();
 
         }
@@ -160,6 +165,7 @@ private void OnPathChanged()
                 return;
             }
             pathData.Update(trainpath);
+            chartWindow.Title = String.Format("{0}: {1}", WindowTitle, pathEditor.CurrentTrainPath.PathName);
             chartWindow.Draw();
         }