Skip to content

Conversation

@dorien-er
Copy link
Contributor

Changelog

Make sure all arguments with type: file have a correct example attached.

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@dorien-er dorien-er changed the title wip Update file examples Aug 25, 2025
Copy link
Member

@DriesSchaumont DriesSchaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you alway use a YAML list please?

input.bam, input.sam, input.cram

becomes

["input.bam", "input.sam", "input.cram"]

@dorien-er dorien-er marked this pull request as draft October 13, 2025 07:49
@dorien-er
Copy link
Contributor Author

Could you alway use a YAML list please?

input.bam, input.sam, input.cram

becomes

["input.bam", "input.sam", "input.cram"]

This results in parsing issues, when we don't set multiple: true

@dorien-er
Copy link
Contributor Author

Could you alway use a YAML list please?

input.bam, input.sam, input.cram

becomes

["input.bam", "input.sam", "input.cram"]

This results in parsing issues, when we don't set multiple: true

Let's discuss offline... May have to rethink the approach for parsing examples to show on VH from the configs

@dorien-er dorien-er marked this pull request as ready for review October 31, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants