-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is enableCacheInterception dangerous? #738
Comments
Well the main reason is that it is not as well tested and that it bypass
I don't think that it is something that we want to enable by default, but with more thorough testing we could move it outside of dangerous |
Thanks for the clarification @conico974 Would it make sense to add the details to https://opennext.js.org/aws/inner_workings/cache_interception ? (and for the context I was looking at what we should recommend to our users) |
Yeah we can add some more info in the docs. As for if it should be recommended on cloudflare, this is probably the place where it is the least interesting. |
I think it could really help when the external middleware is actually external (i.e. in a separate worker) |
ref:
I was wondering why
enableCacheInterception
is ondangerous
and why it is disabled by default?Would it make sense to change that?
/cc @conico974
The text was updated successfully, but these errors were encountered: