Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a closer look at the usage of features for FileDatasets #675

Open
PGijsbers opened this issue Dec 14, 2024 · 0 comments
Open

Have a closer look at the usage of features for FileDatasets #675

PGijsbers opened this issue Dec 14, 2024 · 0 comments
Labels
quality Something needs to be tested, keep the app functional

Comments

@PGijsbers
Copy link
Collaborator

PGijsbers commented Dec 14, 2024

Putting TODOs on the issue tracker instead of in code (#172).

features: list[ns | str]
#TODO: DEADCODE?
I don't see this accessed anywhere, and `features` property is retrieved
from split metadata, which also do not reference this.

The set self._features is currently not used in the code. Could it be used for the features property instead to avoid loading the metadata? Or is no useful information passed and should it be removed from the code base because it is dead code?

@PGijsbers PGijsbers added the quality Something needs to be tested, keep the app functional label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Something needs to be tested, keep the app functional
Projects
None yet
Development

No branches or pull requests

1 participant