We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sería añadir comillas a las variables: $variable --> "$variable" Esta es la explicación de esto: https://github.com/koalaman/shellcheck/wiki/SC2086 Adjunto archivo corregido
OpenGnsys/installer/opengnsys_import.sh
Line 25 in 69fd9c1
Line 67 in 69fd9c1
Line 98 in 69fd9c1
Line 110 in 69fd9c1
Line 111 in 69fd9c1
echo "$DATETIME;$SSH_CLIENT;$1" >> "$LOG_FILE"
Line 118 in 69fd9c1
echo "$DATETIME;$SSH_CLIENT;ERROR: $1" >> "$LOG_FILE"
Line 135 in 69fd9c1
cat << EOT > "$MYCNF"
Line 164 in 69fd9c1
OLDVERSION="$(echo "${file%.*}" | cut -f3 -d-)"
Line 177 in 69fd9c1
if [ -n "$FILES" -o "$OLDVERSION" = "$NEWVERSION" ] && [ -r "$file" ]; then
Line 183 in 69fd9c1
mysql --defaults-extra-file="$MYCNF" -e "CREATE DATABASE $AUXCATALOG"
Line 185 in 69fd9c1
mysql --defaults-extra-file="$MYCNF" -D "$AUXCATALOG" < $MYSQLFILE &>/dev/null
Line 189 in 69fd9c1
importSqlFile $DBDIR/"$file"
mysqldump --defaults-extra-file="$MYCNF" --opt $AUXCATALOG > $MYSQLFILE
Line 196 in 69fd9c1
Line 209 in 69fd9c1
if [ ! -r "$sqlfile" ]; then
Line 216 in 69fd9c1
mysql --defaults-extra-file="$MYCNF" --default-character-set=utf8 -D "$AUXCATALOG" < "$sqlfile"
Line 259 in 69fd9c1
Line 275 in 69fd9c1
Line 276 in 69fd9c1
echo "$PROG: ERROR: Sin acceso al fichero de backup." | tee -a "$FILESAL"
Line 282 in 69fd9c1
echo "$PROG: ERROR: Sin acceso a la configuración de OpenGnsys." | tee -a "$FILESAL"
Line 294 in 69fd9c1
Line 302 in 69fd9c1
tar -xvzf "$BACKUPFILE" --directory /tmp $TARPARAMS &>/dev/null
Line 316 in 69fd9c1
if [ "$OLDVERSION" != "$NEWVERSION" ] ; then
Line 339 in 69fd9c1
if [ ! -r "$MYCNF" ]; then
Line 340 in 69fd9c1
chmod 600 "$MYCNF"
Line 342 in 69fd9c1
Line 373 in 69fd9c1
Line 374 in 69fd9c1
chmod 400 "$MYSQLBCK"
Line 376 in 69fd9c1
mysql --defaults-extra-file="$MYCNF" -D "$CATALOG" < $MYSQLFILE &>/dev/null
Line 382 in 69fd9c1
mv /etc/default/opengnsys /etc/default/opengnsys-"$DATE"
Line 395 in 69fd9c1
Line 397 in 69fd9c1
Line 407 in 69fd9c1
Line 408 in 69fd9c1
Line 421 in 69fd9c1
Line 427 in 69fd9c1
Line 432 in 69fd9c1
mv $OPENGNSYS/www/menus $OPENGNSYS/www/menus-"$DATE"
Line 438 in 69fd9c1
Line 439 in 69fd9c1
Line 450 in 69fd9c1
mv $OPENGNSYS/etc/ogliveinfo.json $OPENGNSYS/etc/ogliveinfo.json-"$DATE"
Un saludo, simplemente le he pasado el shellcheck
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Sería añadir comillas a las variables:
$variable --> "$variable"
Esta es la explicación de esto:
https://github.com/koalaman/shellcheck/wiki/SC2086
Adjunto archivo corregido
OpenGnsys/installer/opengnsys_import.sh
Line 25 in 69fd9c1
PROG="$(basename "$0")"
OpenGnsys/installer/opengnsys_import.sh
Line 67 in 69fd9c1
"$options"
OpenGnsys/installer/opengnsys_import.sh
Line 98 in 69fd9c1
"$MYCNF"
OpenGnsys/installer/opengnsys_import.sh
Line 110 in 69fd9c1
"$LOG_FILE"
OpenGnsys/installer/opengnsys_import.sh
Line 111 in 69fd9c1
echo "$DATETIME;$SSH_CLIENT;$1" >> "$LOG_FILE"
OpenGnsys/installer/opengnsys_import.sh
Line 118 in 69fd9c1
echo "$DATETIME;$SSH_CLIENT;ERROR: $1" >> "$LOG_FILE"
OpenGnsys/installer/opengnsys_import.sh
Line 135 in 69fd9c1
cat << EOT > "$MYCNF"
OpenGnsys/installer/opengnsys_import.sh
Line 164 in 69fd9c1
OLDVERSION="$(echo "${file%.*}" | cut -f3 -d-)"
OpenGnsys/installer/opengnsys_import.sh
Line 177 in 69fd9c1
if [ -n "$FILES" -o "$OLDVERSION" = "$NEWVERSION" ] && [ -r "$file" ]; then
OpenGnsys/installer/opengnsys_import.sh
Line 183 in 69fd9c1
mysql --defaults-extra-file="$MYCNF" -e "CREATE DATABASE $AUXCATALOG"
OpenGnsys/installer/opengnsys_import.sh
Line 185 in 69fd9c1
mysql --defaults-extra-file="$MYCNF" -D "$AUXCATALOG" < $MYSQLFILE &>/dev/null
OpenGnsys/installer/opengnsys_import.sh
Line 189 in 69fd9c1
importSqlFile $DBDIR/"$file"
OpenGnsys/installer/opengnsys_import.sh
Line 189 in 69fd9c1
mysqldump --defaults-extra-file="$MYCNF" --opt $AUXCATALOG > $MYSQLFILE
OpenGnsys/installer/opengnsys_import.sh
Line 196 in 69fd9c1
mysql --defaults-extra-file="$MYCNF" -e "DROP DATABASE $AUXCATALOG"
OpenGnsys/installer/opengnsys_import.sh
Line 209 in 69fd9c1
if [ ! -r "$sqlfile" ]; then
OpenGnsys/installer/opengnsys_import.sh
Line 216 in 69fd9c1
mysql --defaults-extra-file="$MYCNF" --default-character-set=utf8 -D "$AUXCATALOG" < "$sqlfile"
OpenGnsys/installer/opengnsys_import.sh
Line 259 in 69fd9c1
echo "$CONFIG" | jq -r '.[] as $f | $f.comment + ": " + (if $f.detected then "OK" else "FAIL" end)' | column -ts:
OpenGnsys/installer/opengnsys_import.sh
Line 275 in 69fd9c1
if ! [ -r "$BACKUPFILE" ]; then
OpenGnsys/installer/opengnsys_import.sh
Line 276 in 69fd9c1
echo "$PROG: ERROR: Sin acceso al fichero de backup." | tee -a "$FILESAL"
OpenGnsys/installer/opengnsys_import.sh
Line 282 in 69fd9c1
echo "$PROG: ERROR: Sin acceso a la configuración de OpenGnsys." | tee -a "$FILESAL"
OpenGnsys/installer/opengnsys_import.sh
Line 294 in 69fd9c1
checkArchive "$BACKUPFILE"
OpenGnsys/installer/opengnsys_import.sh
Line 302 in 69fd9c1
tar -xvzf "$BACKUPFILE" --directory /tmp $TARPARAMS &>/dev/null
OpenGnsys/installer/opengnsys_import.sh
Line 316 in 69fd9c1
if [ "$OLDVERSION" != "$NEWVERSION" ] ; then
OpenGnsys/installer/opengnsys_import.sh
Line 339 in 69fd9c1
if [ ! -r "$MYCNF" ]; then
OpenGnsys/installer/opengnsys_import.sh
Line 340 in 69fd9c1
chmod 600 "$MYCNF"
OpenGnsys/installer/opengnsys_import.sh
Line 342 in 69fd9c1
cat << EOT > "$MYCNF"
OpenGnsys/installer/opengnsys_import.sh
Line 373 in 69fd9c1
mysqldump --defaults-extra-file="$MYCNF" --opt $CATALOG > "$MYSQLBCK"
OpenGnsys/installer/opengnsys_import.sh
Line 374 in 69fd9c1
chmod 400 "$MYSQLBCK"
OpenGnsys/installer/opengnsys_import.sh
Line 376 in 69fd9c1
mysql --defaults-extra-file="$MYCNF" -D "$CATALOG" < $MYSQLFILE &>/dev/null
OpenGnsys/installer/opengnsys_import.sh
Line 382 in 69fd9c1
mv /etc/default/opengnsys /etc/default/opengnsys-"$DATE"
OpenGnsys/installer/opengnsys_import.sh
Line 395 in 69fd9c1
mv $DHCPCFGDIR/dhcpd.conf $DHCPCFGDIR/dhcpd.conf-"$DATE"
OpenGnsys/installer/opengnsys_import.sh
Line 397 in 69fd9c1
sed "${BEFOREHOST}"q $DHCPCFGDIR/dhcpd.conf-LAST > $DHCPCFGDIR/dhcpd.conf
OpenGnsys/installer/opengnsys_import.sh
Line 407 in 69fd9c1
mkdir -p $OPENGNSYS/tftpboot/$BOOTLOADER-"$DATE"
OpenGnsys/installer/opengnsys_import.sh
Line 408 in 69fd9c1
mv $OPENGNSYS/tftpboot/$BOOTLOADER/{01-*,templates,examples} $OPENGNSYS/tftpboot/$BOOTLOADER-"$DATE" 2>/dev/null
OpenGnsys/installer/opengnsys_import.sh
Line 421 in 69fd9c1
mysql --defaults-extra-file="$MYCNF" -D "$CATALOG" -e "update ordenadores set arranque='10' where arranque='01';" &>/dev/null
OpenGnsys/installer/opengnsys_import.sh
Line 427 in 69fd9c1
mv $OPENGNSYS/client/etc/engine.cfg $OPENGNSYS/client/etc/engine.cfg-"$DATE"
OpenGnsys/installer/opengnsys_import.sh
Line 432 in 69fd9c1
mv $OPENGNSYS/www/menus $OPENGNSYS/www/menus-"$DATE"
OpenGnsys/installer/opengnsys_import.sh
Line 438 in 69fd9c1
mkdir -p $OPENGNSYS/client/scripts/Custom-"$DATE"
OpenGnsys/installer/opengnsys_import.sh
Line 439 in 69fd9c1
mv $OPENGNSYS/client/scripts/*Custom $OPENGNSYS/client/scripts/Custom-"$DATE"
OpenGnsys/installer/opengnsys_import.sh
Line 450 in 69fd9c1
mv $OPENGNSYS/etc/ogliveinfo.json $OPENGNSYS/etc/ogliveinfo.json-"$DATE"
Un saludo, simplemente le he pasado el shellcheck
The text was updated successfully, but these errors were encountered: