Skip to content

Commit c0626f6

Browse files
authored
Fix performance issue
1 parent 8ae5292 commit c0626f6

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

Controller/Adminhtml/Reports/Delete.php

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
use Exception;
1212
use GhostUnicorns\WebapiLogs\Model\Log\Logger;
13-
use GhostUnicorns\WebapiLogs\Model\ResourceModel\Entity\LogCollectionFactory;
13+
use GhostUnicorns\WebapiLogs\Model\Clean;
1414
use Magento\Backend\App\Action;
1515
use Magento\Backend\App\Action\Context;
1616
use Magento\Framework\App\Action\HttpGetActionInterface as HttpGetActionInterface;
@@ -29,9 +29,9 @@ class Delete extends Action implements HttpGetActionInterface
2929
protected $resultPageFactory;
3030

3131
/**
32-
* @var LogCollectionFactory
32+
* @var Clean
3333
*/
34-
private $logCollectionFactory;
34+
private $clean;
3535

3636
/**
3737
* @var Logger
@@ -47,12 +47,12 @@ class Delete extends Action implements HttpGetActionInterface
4747
public function __construct(
4848
Context $context,
4949
PageFactory $resultPageFactory,
50-
LogCollectionFactory $logCollectionFactory,
50+
Clean $clean,
5151
Logger $logger
5252
) {
5353
parent::__construct($context);
5454
$this->resultPageFactory = $resultPageFactory;
55-
$this->logCollectionFactory = $logCollectionFactory;
55+
$this->clean = $clean;
5656
$this->logger = $logger;
5757
}
5858

@@ -62,10 +62,7 @@ public function __construct(
6262
public function execute()
6363
{
6464
try {
65-
$logs = $this->logCollectionFactory->create();
66-
foreach ($logs as $log) {
67-
$log->delete();
68-
}
65+
$this->clean->cleanAll();
6966
} catch (Exception $exception) {
7067
$this->logger->error(__('Cant delete webapi log because of error: %1', $exception->getMessage()));
7168
}

0 commit comments

Comments
 (0)