Skip to content

Commit f64458d

Browse files
authored
fix(react): revert react output target version (ionic-team#29869)
Issue number: resolves stenciljs/output-targets#476, resolves stenciljs/output-targets#475, resolves ionic-team#29848 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> In v0.6.0 of the [React output target](https://www.npmjs.com/package/@stencil/react-output-target), the implementation was changed to leverage Lit's utility for creating React components from web components. This introduced some unforseen issues and breaking changes. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Reverts many of the changes from ionic-team#29782 to downgrade the React output target package to the last stable version (v0.5.3) - Downgrades the version of Stencil to v4.20.0 (due to stenciljs/core#5983 causing problems with the downgraded output target) - Pins these versions and prevents Renovate from attempting to upgrade until the associated issues are resolved ## Does this introduce a breaking change? - [ ] Yes - [X] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build for this version: `8.3.1-dev.11726167750.15400355` I tested the dev build against the use cases outlined in stenciljs/output-targets#475 and stenciljs/output-targets#476
1 parent ab7a0ab commit f64458d

File tree

11 files changed

+269
-1290
lines changed

11 files changed

+269
-1290
lines changed

core/package-lock.json

+38-222
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"loader/"
3232
],
3333
"dependencies": {
34-
"@stencil/core": "^4.19.2",
34+
"@stencil/core": "4.20.0",
3535
"ionicons": "^7.2.2",
3636
"tslib": "^2.1.0"
3737
},
@@ -48,7 +48,7 @@
4848
"@rollup/plugin-node-resolve": "^8.4.0",
4949
"@rollup/plugin-virtual": "^2.0.3",
5050
"@stencil/angular-output-target": "^0.8.4",
51-
"@stencil/react-output-target": "^0.6.0",
51+
"@stencil/react-output-target": "0.5.3",
5252
"@stencil/sass": "^3.0.9",
5353
"@stencil/vue-output-target": "^0.8.9",
5454
"@types/jest": "^29.5.6",

core/stencil.config.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,11 @@ export const config: Config = {
124124
],
125125
outputTargets: [
126126
reactOutputTarget({
127-
outDir: '../packages/react/src/components/',
127+
componentCorePackage,
128+
includeImportCustomElements: true,
129+
includePolyfills: false,
130+
includeDefineCustomElements: false,
131+
proxiesFile: '../packages/react/src/components/proxies.ts',
128132
excludeComponents: [
129133
// Routing
130134
'ion-router',

packages/react/.prettierignore

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ dist
22
dist-transpiled
33
*.md
44
build
5-
components.ts
5+
proxies.ts
66
react-component-lib

0 commit comments

Comments
 (0)