-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto receive report by email when OC closes #160
Comments
Hello @seballot first of all thank you for all your suggestions! Keep them comiiiing ❤️ Just to let you know the community is currently gathering in Portugal, so we are a bit slow to answer on github / slack :) A few feedback in the meanwhile here:
Some hubs are against this because after the OC closes, they edit orders before sending the info to the producers. That's how we ended up with a button. So one idea is to make the automatic email optional as a checkbox indeed. We are talking about it here: https://github.com/openfoodfoundation/wishlist/issues/143 Are you happy if we keep this issue to follow the conversation? Also linked: #100
I would suggest we open a new issue for this one, what do you think? Maybe it's something that can be done quickly if we divide 1 issue per report? To deliver them step by step? |
Hi @RachL thanks for feedback !
I don't think one issue per report is needed, it's the same job to do all of them together Should we add this report selection on the OC config, or globally at the entreprise level? I was thing globally, but in #143 it's per OC so I guess we should do the same here? |
Hi @seballot |
Hi @lin-d-hop, We don't need webhook here, webhook are for different websites/apps to communicate But what I think we need is
Then in the email, we can either attach the report (PDF, CSV, XLSX), or put a link in the email to download the report, or display the report directly inside the email with HTML format, or all of those solutions together :) -> estimate 3h WDYT? |
While 'sending a report on OC close' is one feature people occasionally want... actually there are a lot of functions people want to do on OC close like:
With report data on the API we can achieve all of this. So while your solution might take you 9hrs, and that's great, the utility is limited and doesn't solve a huge number of problems for people. In general the OFN app is too complex so I am always looking for ways to simplify the app. Im also bringing the knowledge that most features we use are not widely used because they often dont quite serve the need. So I am therefore in favour of finding ways of creating max value with min features and maximum flexibility. I think a webhook on OC close does this. Of course if you wanted to develop your feature I wouldn't stop you. The 'custom report' feature in particular would be very welcomed. Though I might ask we make an epic that also includes a webhook so we can deliver even more value. WDYT? |
Hi ! Oh, so you want a webhook at OC closes so users can catch this webhook within their own system and implement the functionalities you described? and, maybe, if one of the thing people want to do when OC closes is popular enough, implement the functionality inside OFN. But otherwise let users do what they want, is that right? webhook is very easy to implement, it's 2hour of work |
@seballot I wonder if you would be interested in implementing the first OFN webhook? We have an OFN N8N instance now so catching the webhook to send reports could be super easy and, of course, you'd be welcome to have an account there and use for your hub :) |
Dear @lin-d-hop, |
OFN Webhook on OC open close is in development. After this this issue can move to something for N8N |
Happy to implement it myself if the feature is agreed
What is the need / problem?
Automatically receive a report after OC closes
Which type of users does this problem affect (and how many, if known)?
- Hub Managers (MCFEs)
Potential solutions that will solve the problem ?[[brainstorming to list feature candidates]
The text was updated successfully, but these errors were encountered: