GitHub Actions Migration - tracking issue

[Waterdrips]

Inlets

• https://github.com/inlets/inlets-operator @jsiebens
• https://github.com/inlets/inletsctl
• https://github.com/inlets/inlets

alexellis

• k3sup @alexellis
• arkade @Waterdrips
• https://github.com/alexellis/derek

openfaas

Merged:

• https://github.com/openfaas/faas-netes @akosveres
• https://github.com/openfaas/templates @Waterdrips
• https://github.com/openfaas/nats-connector @CodeCutterUK
• https://github.com/openfaas/faasd @akosveres
• https://github.com/openfaas/ofc-bootstrap @Waterdrips
• https://github.com/openfaas/faas-provider closed in migrate travis ci to github actions faas-provider#49
• https://github.com/openfaas/faas-cli
• https://github.com/openfaas/kafka-connector
• https://github.com/openfaas/cron-connector
• https://github.com/openfaas/openfaas-cloud @Waterdrips

Waiting on Review:

• https://github.com/openfaas/nats-queue-worker pending: Move from Travis CI to Github Actions nats-queue-worker#103
• https://github.com/openfaas/ingress-operator pending: Convert CI to GitHub Actions ingress-operator#42
• https://github.com/openfaas/faas-idler pending https://github.com/openfaas/faas-idler/pull/44
• https://github.com/openfaas/faas-swarm pending: Use buildx and github actions faas-swarm#76
• https://github.com/openfaas/certifier pending feat(actions): add github workflows for test certifier#58
• https://github.com/openfaas/of-watchdog pending Migration to Github Actions and multiarch builds of-watchdog#114
• https://github.com/openfaas/connector-sdk pending github actions workflow enabled connector-sdk#53
• https://github.com/openfaas/faas pending Convert to Github Actions #1598

Pending:

• https://github.com/openfaas/store
• https://github.com/openfaas/mqtt-connector

OpenFaaS Incubator

• https://github.com/openfaas-incubator/openfaas-sqs-connector
• https://github.com/openfaas-incubator/openfaas-vcenter-connector

[Waterdrips]

/open

[Waterdrips]

/reopen

[alexellis]

Folks unfortunately the first set of merged PRs did not work as I don't believe that we tested them in our branches with a release tag before submitting the PR and asking for a merge. Let's tighten up our work before asking for a merge?

Make sure release tags work

I also noticed that the Docker v2 build/push action does not copy in a .git folder, this can be worked-around as follows (with a path and context). When these are missing, the code does a fresh clone / checkout of the code and lacks the .git folder used to get versions and tags.

      - name: Build multi-arch containers for validation only
        uses: docker/build-push-action@v2
        with:
          context: .
          file: ./Dockerfile
          outputs: "type=image,push=false"
          platforms: linux/amd64,linux/arm/v7,linux/arm64
          tags: |
            ghcr.io/openfaas/faas-netes:${{ github.sha }}

Include a NS variable in the image name

In order to test in our own repos, we should each have some way of overwriting ghcr.io/openfaas/faas-netes:${{ github.sha }} with our own username i.e. ghcr.io/NS/faas-netes:${{ github.sha }} where NS is a GitHub Action env-var. Have a look at https://docs.github.com/en/free-pro-team@latest/actions/reference/environment-variables

Keep naming consistent

I noticed that in most PRs people changed the name of the build and publish step to whatever they preferred. Please don't. Let's make sure this is consistent for future maintenance. Match the build job with the filename too.

Build on *

Many PRs just assumed only master would be used

on:
  push:
    branches:
    - '*'
  pull_request:
    branches:
    - '*'

• build.yaml - upon * for push and branches
• publish.yaml - upon tags

Make sure this is multi-arch with buildx

We need to build for multiple architectures, not just x86_64 - see the faas-netes build or the other references examples on trello.

Remove .travis.yml and travis_terminate

Remove the .travis.yml file

Remove the travis_terminate command in bash files.

Make sure the Go version is set when required

jobs:
  build:
    strategy:
      matrix:
        go-version: [1.13.x]
        os: [ubuntu-latest]
    runs-on: ${{ matrix.os }}
    steps:
      - uses: actions/checkout@master
        with:
          fetch-depth: 1
      - name: Install Go
        uses: actions/setup-go@v2
        with:
          go-version: ${{ matrix.go-version }}

Some people set the Go version to 1.11, 1.9 and 1.14 - for the time being we're using 1.13, but only configure the Go version if Go is used in the actions. For most of the openfaas repos Go isn't used at all at build-time, Docker is.

Link the artifact to the repo