Skip to content

Conversation

@NormanZielke
Copy link

closes #814

@NormanZielke NormanZielke requested review from CarlosEpia, ClaraBuettner and mohsenmansouri and removed request for ClaraBuettner October 8, 2025 21:52
@CarlosEpia
Copy link
Contributor

Hi Norman,
It was decided that the hybit branch will not be merged into dev. Other branches, partialy based on the hybit one, replaced it and are suppose to be merged in the future. For example #800

@NormanZielke NormanZielke force-pushed the feature/modeling_on_interest_area branch from d5d4fd5 to 1d954ce Compare October 14, 2025 11:07
@NormanZielke NormanZielke force-pushed the feature/modeling_on_interest_area branch from b09b09b to ee7823a Compare October 14, 2025 11:14
…cus' into feature/modeling_on_interest_area

# Conflicts:
#	etrago/appl.py
#	etrago/args.json
#	etrago/cluster/electrical.py
#	etrago/cluster/gas.py
#	etrago/cluster/spatial.py
#	etrago/network.py
#	etrago/tools/utilities.py
@NormanZielke NormanZielke changed the base branch from hybit to features/#800-clustering-with-focus October 14, 2025 12:43
@NormanZielke NormanZielke marked this pull request as draft October 20, 2025 18:40
@KathiEsterl
Copy link
Contributor

Hi,

great to see that you used eTraGo for your master’s thesis, and thanks for contributing new functionalities!

At first glance, it looks quite specific — tailored to Ingolstadt as an example — which isn’t exactly what eTraGo is designed for.

One of us (@ClaraBuettner , @CarlosEpia , or me) will definitely take a closer look before merging this into the zooming branch, which is meant to be more generic and focused on applying clustering methods to specific regions.

Thanks!

@NormanZielke
Copy link
Author

Hi,

I'm currently working on, to run my code on the new branch.

when running the model on the features/#800-clustering-with-focus branch, the network does not focus on my interest area. When I plot the buses, none appear in Ingolstadt.

⚙️ Clustering settings I use

  • args["network_clustering"]["method"]["focus_region"]: ["Ingolstadt"]
  • args["network_clustering"]["electricity_grid"]["cluster_within_focus"]: 1

I assumed, these are the corresponding setting parameter as before in hybit branch:

  • args["interest_area"]: ["Ingolstadt"]
  • args["network_clustering"]["n_cluster_interest_area"]: 1

I think, this is all I need to adjust for the clustering. My assumption is with these settings I should get similar results as before in the hybit branch. But unfortunately I'm not able to zoom on my interest area. If I plot the buses of the network, I don't get any buses in Ingolstadt.

Is there something I missed here? There are some other parameters I have adapt in the features/#800-clustering-with-focus branch for the clustering - procedure?

Otherwise I can't explain, why I'm not able to zoom on my interest area.

@KathiEsterl I tried to wrote my functionalities generic as possible. The whole procedure should be working generic with these two arguments.

  • args["network_clustering"]["method"]["focus_region"]: ["interest_area"]
  • args["network_clustering"]["n_cluster_interest_area"]: 1

That means you don't need bus-ids etc. Is that what you mean?
Only the component parameters are specific. That means you have to define them in the functions. And coords. are provided only where necessary, e.g. for new elements/buses located in Ingolstadt.

@KathiEsterl
Copy link
Contributor

Without knowing the full context, it looks to me as if you were adding some features specifically related to the Ingolstadt area — but perhaps I misunderstood.

Can we have a meeting to discuss the purpose of the various developments and branches, and then decide together on the best procedure? :)

It would be great if you could contact me by email to arrange a suitable time: [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants