Skip to content

Fix Python and JavaScript (Karma) tests for Problem XBlock #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
irtazaakram wants to merge 3 commits into
base: problemblock
Choose a base branch
from
Open

Fix Python and JavaScript (Karma) tests for Problem XBlock #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0497fd
fix: python & javascript tests
irtazaakram Feb 3, 2026
7b67d3d
fix: packaging issues
irtazaakram Feb 4, 2026
9c42194
fix: build issues
irtazaakram Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/javascript-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [20]
node-version: [24]

steps:
- name: Check out repository
Expand Down Expand Up @@ -41,7 +41,7 @@ jobs:
sudo apt-get install -y libdbus-glib-1-2 libgtk-3-0 xvfb
- name: Install npm dependencies
run: npm ci
run: npm install
Copy link
Contributor

@salman2013 salman2013 Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any specific reason of using npm install, ideally we should use npm ci for CI.


- name: Run tests
run: npm run test:ci || echo "⚠️ Tests skipped — no workspaces available"
run: xvfb-run --auto-servernum npm run test || echo "⚠️ Tests skipped — no workspaces available"
10 changes: 10 additions & 0 deletions .github/workflows/pypi-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@ jobs:
with:
python-version: 3.12

- name: Set up Node.js
uses: actions/setup-node@v6
with:
node-version: '24'

- name: Build JavaScript bundles
run: |
npm install
Copy link
Contributor

@salman2013 salman2013 Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above comment.
https://github.com/openedx/xblocks-contrib/pull/151/changes#r2773284533

npm run build

- name: Install dependencies
run: pip install -r requirements/pip.txt

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
name: Run Python Tests and Coverage
runs-on: ubuntu-latest
strategy:
fail-fast: true
fail-fast: false
matrix:
python-version: ["3.11", "3.12"]
toxenv: [quality, docs, django42, django52]
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ __pycache__
/.installed.cfg
/lib
/lib64
node_modules
public

# Installer logs
pip-log.txt
Expand All @@ -34,6 +36,7 @@ pip-log.txt
.tox
coverage.xml
htmlcov/
coverage/

# Virtual environments
/venv/
Expand Down
2 changes: 1 addition & 1 deletion MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ include LICENSE.txt
include README.rst
include requirements/base.in
include requirements/constraints.txt
recursive-include xblocks_contrib *.html *.png *.gif *.js *.css *.jpg *.jpeg *.svg
recursive-include xblocks_contrib *.html *.png *.gif *.js *.css *.jpg *.jpeg *.svg **/public *
Loading
Loading