Fix Python and JavaScript (Karma) tests for Problem XBlock#151
Open
irtazaakram wants to merge 3 commits intoproblemblockfrom
Open
Fix Python and JavaScript (Karma) tests for Problem XBlock#151irtazaakram wants to merge 3 commits intoproblemblockfrom
irtazaakram wants to merge 3 commits intoproblemblockfrom
Conversation
irtazaakram
changed the title
irtazaakram
changed the title
irtazaakram
force-pushed
the
fix-problemblock
branch
from
77fd1b6 to
3c433b8
Compare
irtazaakram
force-pushed
the
fix-problemblock
branch
from
3c433b8 to
e0497fd
Compare
salman2013
requested changes
Feb 6, 2026
| - name: Install npm dependencies | ||
| run: npm ci | ||
| run: npm install |
Contributor
There was a problem hiding this comment.
any specific reason of using npm install, ideally we should use npm ci for CI.
|
|
||
| - name: Build JavaScript bundles | ||
| run: | | ||
| npm install |
Contributor
There was a problem hiding this comment.
same as above comment.
https://github.com/openedx/xblocks-contrib/pull/151/changes#r2773284533
| minimize: false | ||
| }, | ||
| mode: 'development', | ||
| devtool: 'source-map' |
Contributor
There was a problem hiding this comment.
For production this should be false, so ideally we should add different configuration files for dev and prod.
| "scripts": { | ||
| "test": "npm run test --workspaces", | ||
| "test:ci": "npm run test:ci --workspaces" | ||
| "build": "npm run build --workspaces", |
Contributor
There was a problem hiding this comment.
ideally separate script should be available like build-dev and build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Python and JavaScript (Karma) tests for the newly extracted Problem (CAPA) XBlock.
Context
What Changed
tests/to align with the new directory structure.npm build.Notes