Skip to content

Commit ed88f06

Browse files
chore: fix quality issues
1 parent 703c0cf commit ed88f06

3 files changed

Lines changed: 12 additions & 4 deletions

File tree

openedx_learning/apps/authoring/containers/api.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ def create_next_defined_list(
124124
EntityListRow.objects.bulk_create(new_rows)
125125
return new_entity_list
126126

127+
127128
def create_defined_list_with_rows(
128129
entity_pks: list[int],
129130
entity_version_pks: list[int | None],
@@ -527,7 +528,7 @@ def contains_unpublished_changes(
527528
"publishable_entity__draft__version__containerentityversion__defined_list",
528529
).get(pk=container.container_entity_id)
529530
else:
530-
pass # TODO: select_related if we're given a raw ContainerEntity rather than a ContainerEntityMixin like Unit?
531+
pass # TODO: select_related if we're given a raw ContainerEntity rather than a ContainerEntityMixin like Unit?
531532
assert isinstance(container, ContainerEntity)
532533

533534
if container.versioning.has_unpublished_changes:
@@ -546,7 +547,7 @@ def contains_unpublished_changes(
546547
):
547548
try:
548549
child_container = row.entity.containerentity
549-
except PublishableEntity.containerentity.RelatedObjectDoesNotExist: # type: ignore[attr-defined] # pylint: disable=no-member
550+
except ContainerEntity.DoesNotExist:
550551
child_container = None
551552
if child_container:
552553
child_container = row.entity.containerentity

openedx_learning/apps/authoring/containers/apps.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ class ContainersConfig(AppConfig):
1515
default_auto_field = "django.db.models.BigAutoField"
1616
label = "oel_containers"
1717

18-
1918
def ready(self):
2019
"""
2120
Register ContainerEntity and ContainerEntityVersion.

tests/openedx_tagging/core/tagging/test_views.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1042,7 +1042,15 @@ def test_object_tags_remaining_http_methods(
10421042
("staff", "taxonomy", {}, ["Invalid"], status.HTTP_400_BAD_REQUEST, "abc.xyz"),
10431043
)
10441044
@ddt.unpack
1045-
def test_tag_object(self, user_attr, taxonomy_attr, taxonomy_flags, tag_values, expected_status, object_id): # pylint: disable=too-many-positional-arguments
1045+
def test_tag_object( # pylint: disable=too-many-positional-arguments
1046+
self,
1047+
user_attr,
1048+
taxonomy_attr,
1049+
taxonomy_flags,
1050+
tag_values,
1051+
expected_status,
1052+
object_id,
1053+
):
10461054
if user_attr:
10471055
user = getattr(self, user_attr)
10481056
self.client.force_authenticate(user=user)

0 commit comments

Comments
 (0)