Skip to content

i18n: extract hardcoded status strings in ProgramRecordsList#685

Open
jia-dodeja wants to merge 2 commits into
openedx:masterfrom
jia-dodeja:fix-issue-457
Open

i18n: extract hardcoded status strings in ProgramRecordsList#685
jia-dodeja wants to merge 2 commits into
openedx:masterfrom
jia-dodeja:fix-issue-457

Conversation

@jia-dodeja

Copy link
Copy Markdown

What does this PR do?

This PR fixes the hardcoded 'Completed' and 'Partially Completed' strings in ProgramRecordsList.jsx by wrapping them in the project's i18n system. I added message descriptors using defineMessages and replaced the hardcoded strings with intl.formatMessage() calls so they can be translated into the user's language.

Why was this PR needed?

Issue #457 pointed out that these two status strings were hardcoded in JavaScript, meaning they always showed up in English even when the rest of the interface was translated. Since the strings are assigned to a variable in logic rather than rendered directly in JSX, intl.formatMessage() is the right pattern to use here — which matches how other components in the codebase handle the same situation.

What are the relevant issue numbers?

Closes #457

Does this PR meet the acceptance criteria?

  • Tests added for new/changed behavior
  • All tests passing (76/78; 2 pre-existing failures in SendLearnerRecordModal are unrelated to this change)
  • Follows project i18n patterns
  • No breaking changes introduced

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 29, 2026
@openedx-webhooks

openedx-webhooks commented Jun 29, 2026

Copy link
Copy Markdown

Thanks for the pull request, @jia-dodeja!

This repository is currently maintained by @jajjibhai008.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@jia-dodeja

Copy link
Copy Markdown
Author

Hi @jajjibhai008, this is my first contribution to this project. I've extracted the hardcoded 'Completed' and 'Partially Completed' status strings in ProgramRecordsList.jsx into i18n message descriptors (closes #457). I've submitted the CLA and the PR is ready for engineering review when you get a chance!

@mphilbrick211

Copy link
Copy Markdown

Hi @jia-dodeja! Welcome, and thank you for this contribution! In order for your CLA check to turn green, you'll need to submit a CLA form. If you are contributing as an individual, please fill out the individual CLA form here.

If you are contributing on behalf of an organization, please have your manager reach out to oscm@axim.org so you may be added to your org's existing entity agreement.

Please let me know if you have any questions. Thanks!

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Jul 6, 2026
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 6, 2026
@jia-dodeja

Copy link
Copy Markdown
Author

Hi @mphilbrick211! I have filled out the CLA form already as well as the DocuSign document.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 13, 2026
@e0d

e0d commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@jia-dodeja Looks like there are some check failures, please have a look.

@e0d e0d moved this from Needs Tests Run or CLA Signed to Waiting on Author in Contributions Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: No status
Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

Help wanted: Extract "Completed" and "Partially Completed" into i18n messages

5 participants