Skip to content

Commit 7ca3d9b

Browse files
bydawenarbrandes
authored andcommitted
build: Upgrade to Node 24
1 parent d4a6c20 commit 7ca3d9b

File tree

7 files changed

+2197
-1284
lines changed

7 files changed

+2197
-1284
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ jobs:
1212
strategy:
1313
matrix:
1414
node: [20, 24]
15-
continue-on-error: ${{ matrix.node == 24 }}
1615

1716
steps:
1817
- name: Checkout
@@ -22,7 +21,7 @@ jobs:
2221
- name: Setup Nodejs
2322
uses: actions/setup-node@v4
2423
with:
25-
node-version: ${{ matrix.node }}
24+
node-version-file: '.nvmrc'
2625
- name: Install dependencies
2726
run: npm ci
2827
- name: Validate package-lock.json changes

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20
1+
24

package-lock.json

Lines changed: 2178 additions & 1279 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/components/TinyMCEEditor.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { ActionRow, AlertModal, Button } from '@openedx/paragon';
44
import { Editor } from '@tinymce/tinymce-react';
55
import { useLocation, useParams } from 'react-router-dom';
66
// TinyMCE so the global var exists
7-
// eslint-disable-next-line no-unused-vars,import/no-extraneous-dependencies
7+
/* eslint-disable-next-line @typescript-eslint/no-unused-vars, import/no-extraneous-dependencies */
88
import tinymce from 'tinymce/tinymce';
99

1010
import { useIntl } from '@edx/frontend-platform/i18n';

src/discussions/common/time-locale.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// eslint-disable-next-line no-unused-vars
1+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
22
export default function timeLocale(number, index, totalSec) {
33
return [
44
['just now', 'right now'],

src/discussions/post-comments/data/hooks.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ export const useDraftContent = () => {
152152
};
153153

154154
const removeItem = (draftData, objId) => {
155+
/* eslint-disable-next-line @typescript-eslint/naming-convention */
155156
const { [objId]: _, ...newDraftData } = draftData;
156157
return newDraftData;
157158
};

tsconfig.json

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
{
2+
"extends": "@edx/typescript-config",
3+
"compilerOptions": {
4+
"noEmit": true,
5+
"baseUrl": "./src",
6+
"paths": {
7+
"*": ["*"]
8+
},
9+
"jsx": "react-jsx",
10+
"allowJs": true
11+
},
12+
"include": ["*.js", ".eslintrc.js", "src/**/*", "plugins/**/*"],
13+
"exclude": ["dist", "node_modules"]
14+
}

0 commit comments

Comments
 (0)