Conversation
Moves the Program Dashboard APIs out of the deprecated remnants of the legacy learner dashboard, into the Programs djangoapp. Keeps the old legacy routes for this API, left over from the deprecated remnants of the legacy learner dashboard, alongside future-proofed routes which will work when the deprecated, legacy Program Dashboard is replaced with functionality in the Learner Dashboard MFE. FIXES: APER-3949
…re-useful-code-from-deprecated-learner_dashboard-to-current-programs-djangoapp
removing left over duplicate test
fixing the tests so that they will load on CMS but also don't run there.
| 'openedx.core.djangoapps.content.search', | ||
|
|
||
| # For Programs API | ||
| 'lms.djangoapps.program_enrollments', |
There was a problem hiding this comment.
I feel like I'm missing something here -- why is this change needed?
I don't see anything in this PR that affects the program_enrollments app.
There was a problem hiding this comment.
because even having marked all of the tests as lms_only, running the CMS test suite as the CI matrix does ( eg. python -Wd -m pytest -p no:randomly --ds=cms.envs.test openedx/core/djangoapps/programs) failed, kvetching about test_views import from program_enrollments (from lms.djangoapps.program_enrollments.tests.factories import ProgramEnrollmentFactory). I believe this happened because I moved to these tests from the LMS to OpenEdx core, so the imports weren't all already there.
There was a problem hiding this comment.
Ah, thanks for the explanation. That makes more sense!
|
|
||
| import logging | ||
|
|
||
| from enterprise.models import EnterpriseCourseEnrollment |
There was a problem hiding this comment.
I know we're mostly just moving code around to help support a pending DEPR. It would be nice if we're touching some of these files to remove the direct imports of models from other Django apps.
If we don't fix this here and now, can we at least get a ticket in the backlog to remove the direct import and use of the EnterpriseCourseEnrollment and CourseEnrollment models in this file?
There was a problem hiding this comment.
I'm working on cleanup tickets now, and that would be a great cleanup ticket, so I will go ahead and create that right away. Nice catch.
deborahgu
deleted the
dkaplan1/APER-3949_move-currently-and-future-useful-code-from-deprecated-learner_dashboard-to-current-programs-djangoapp
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Moves the Program Dashboard APIs out of the deprecated remnants of the legacy learner dashboard, into the Programs djangoapp. Keeps the old legacy routes for this API, left over from the deprecated remnants of the legacy learner dashboard, alongside future-proofed routes which will work when the deprecated, legacy Program Dashboard is eventually replaced with functionality in the Learner Dashboard MFE. FIXES: APER-3949
Moves the Program Dashboard APIs out of the deprecated remnants of the legacy learner dashboard, into the Programs djangoapp. Keeps the old legacy routes for this API, left over from the deprecated remnants of the legacy learner dashboard, alongside future-proofed routes which will work when the deprecated, legacy Program Dashboard is eventually replaced with functionality in the Learner Dashboard MFE. FIXES: APER-3949
Moves the Program Dashboard APIs out of the deprecated remnants of the legacy learner dashboard, into the Programs djangoapp. Keeps the old legacy routes for this API, left over from the deprecated remnants of the legacy learner dashboard, alongside future-proofed routes which will work when the deprecated, legacy Program Dashboard is eventually replaced with functionality in the Learner Dashboard MFE. FIXES: APER-3949
3 participants
Description
Moves the Program Dashboard APIs out of the deprecated remnants of the legacy learner dashboard, into the Programs djangoapp.
Keeps the old legacy routes for this API, left over from the deprecated remnants of the legacy learner dashboard, alongside future-proofed routes which will work when the deprecated, legacy Program Dashboard is replaced with functionality in the Learner Dashboard MFE.
FIXES: APER-3949