✅ Add formatOptions test

Signed-off-by: Muhammed Hussein Karimi <[email protected]>

Author: mhkarimi1383

tests/provision_test.go

@@ -86,6 +86,24 @@ func fsVolCreationTest() {
 	}
 }
 
+func formatOptionsTest() {
+	formatOptions := "-b 4096 -N 5000000"
+	By("####### Creating the storage class with formatOptions : " + formatOptions + " #######")
+	createFormatOptionsStorageClass(formatOptions)
+	By("Creating and verifying PVC bound status")
+	createAndVerifyPVC(true)
+	By("Creating and deploying app pod", createDeployVerifyFormatOptions)
+	By("Verifying LVMVolume object to be Ready")
+	VerifyLVMVolume(true, "")
+	By("Verifing LVM Volume format options")
+	VerifyLVMVolumeFormatOptions(formatOptions)
+	By("Deleting verifier pvc/pod")
+	deleteAppAndPvc([]string{"format-options-verifier"}, pvcName)
+	By("Verifying that PV is deleted after deletion")
+	verifyPVForPVC(false, pvcName)
+	By("Deleting storage class", deleteStorageClass)
+}
+
 func blockVolCreationTest() {
 	By("Creating default storage class", createStorageClass)
 	By("Creating and verifying PVC bound status")
@@ -321,6 +339,7 @@ func volumeCreationTest() {
 	device := setupVg(40, "lvmvg")
 	defer cleanupVg(device, "lvmvg")
 	By("###Running filesystem volume creation test###", fsVolCreationTest)
+	By("###Running filesystem with formatOptions creation test###", formatOptionsTest)
 	By("###Running block volume creation test###", blockVolCreationTest)
 	By("###Running thin volume creation test###", thinVolCreationTest)
 	By("###Running leak protection test###", leakProtectionTest)

tests/utils.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"path/filepath"
+	"strings"
 
 	"github.com/onsi/ginkgo"
 	"github.com/onsi/gomega"
@@ -233,6 +234,29 @@ func createThinStorageClass() {
 	gomega.Expect(err).To(gomega.BeNil(), "while creating a thinProvision storageclass {%s}", scName)
 }
 
+func createFormatOptionsStorageClass(formatOptions string) {
+	var (
+		err error
+	)
+
+	parameters := map[string]string{
+		"volgroup":      VOLGROUP,
+		"formatOptions": formatOptions,
+	}
+
+	ginkgo.By("building a default storage class")
+	scObj, err = sc.NewBuilder().
+		WithGenerateName(scName).
+		WithVolumeExpansion(true).
+		WithParametersNew(parameters).
+		WithProvisioner(LocalProvisioner).Build()
+	gomega.Expect(err).ShouldNot(gomega.HaveOccurred(),
+		"while building formatOptions storageclass obj with prefix {%s}", scName)
+
+	scObj, err = SCClient.Create(scObj)
+	gomega.Expect(err).To(gomega.BeNil(), "while creating a storageclass with formatOptions {%s}", scName)
+}
+
 // VerifyLVMVolume verify the properties of a lvm-volume
 // expected_vg is supposed to be passed only when vgpatten was used for scheduling.
 // If its volgroup in sc then we can just match volgroup with lvmvolume's vg field.
@@ -271,6 +295,18 @@ func VerifyLVMVolume(expect_ready bool, expected_vg string) {
 	}
 }
 
+func VerifyLVMVolumeFormatOptions(formatOptions string) {
+	ginkgo.By("fetching lvm volume")
+	vol_name := pvcObj.Spec.VolumeName
+	vol, err := LVMClient.WithNamespace(OpenEBSNamespace).
+		Get(vol_name, metav1.GetOptions{})
+	gomega.Expect(err).To(gomega.BeNil(), "while fetching the lvm volume {%s}", pvcObj.Spec.VolumeName)
+	gomega.Expect(vol).To(gomega.Not(gomega.BeNil()), "LVMVolume Obj is Nil")
+	gomega.Expect(vol.ObjectMeta.Name).To(gomega.Not(gomega.Equal(vol_name)), "LVMVolume mismatch")
+	gomega.Expect(vol.Spec.FormatOptions).To(gomega.Equal(strings.Split(formatOptions, " ")),
+		"While checking if lvmvolume: %s has correct formatOptions", pvcObj.Spec.VolumeName)
+}
+
 func deleteStorageClass() {
 	err := SCClient.Delete(scObj.Name, &metav1.DeleteOptions{})
 	gomega.Expect(err).To(gomega.BeNil(),
@@ -560,6 +596,77 @@ func createAndDeployBlockAppPod() {
 	}
 }
 
+func createDeployVerifyFormatOptions() {
+	ginkgo.By("creating and deploying verifier pod")
+	createAndDeployVerifyFormatOptions()
+	ginkgo.By("verifying verifier pod is running", verifyAppPodRunning)
+}
+
+func createAndDeployVerifyFormatOptions() {
+	var err error
+	appname := "format-options-verifier"
+	labels := map[string]string{
+		"role": "test",
+		"app":  appname,
+	}
+	ginkgo.By("building app " + appname + " using above lvm volume")
+	deployObj, err = deploy.NewBuilder().
+		WithName(appname).
+		WithNamespace(OpenEBSNamespace).
+		WithLabelsNew(labels).
+		WithSelectorMatchLabelsNew(labels).
+		WithPodTemplateSpecBuilder(
+			pts.NewBuilder().
+				WithLabelsNew(labels).
+				WithContainerBuilders(
+					container.NewBuilder().
+						WithImage("debian:stable-slim").
+						WithName("verifier").
+						WithImagePullPolicy(corev1.PullIfNotPresent).
+						WithEnvsNew(
+							[]corev1.EnvVar{
+								{
+									Name:  "EXPECTED_INODES",
+									Value: "5001264",
+								},
+							},
+						).
+						WithCommandNew(
+							[]string{
+								"bash",
+								"-c",
+								`export DEVICE=$(df --output=source '/mnt/datadir' | tail -n 1); export ACTUAL_INODES=$(tune2fs -l "$DEVICE" | grep "Inode count" | awk '{print $3}'); [ "$ACTUAL_INODES" -eq "$EXPECTED_INODES" ] && echo "Inode count is correct: $ACTUAL_INODES" && exit 0 || echo "Inode count mismatch: expected $EXPECTED_INODES, but got $ACTUAL_INODES" && exit 1`,
+							},
+						).
+						WithVolumeMountsNew(
+							[]corev1.VolumeMount{
+								{
+									Name: "datavol1",
+									// If this path changes, modify the above fio command line accordingly.
+									MountPath: "/mnt/datadir",
+								},
+							},
+						),
+				).
+				WithVolumeBuilders(
+					k8svolume.NewBuilder().
+						WithName("datavol1").
+						WithPVCSource(pvcObj.Name),
+				),
+		).
+		Build()
+
+	gomega.Expect(err).ShouldNot(gomega.HaveOccurred(), "while building app deployement {%s}", appname)
+
+	deployObj, err = DeployClient.WithNamespace(OpenEBSNamespace).Create(deployObj)
+	gomega.Expect(err).ShouldNot(
+		gomega.HaveOccurred(),
+		"while creating pod {%s} in namespace {%s}",
+		appname,
+		OpenEBSNamespace,
+	)
+}
+
 func createDeployVerifyBlockApp() {
 	ginkgo.By("creating and deploying app pod", createAndDeployBlockAppPod)
 	ginkgo.By("verifying app pod is running", verifyAppPodRunning)