Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRUCacheInterface lacks of virtual destructor #2880

Closed
skypexu opened this issue Nov 9, 2023 · 0 comments
Closed

LRUCacheInterface lacks of virtual destructor #2880

skypexu opened this issue Nov 9, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@skypexu
Copy link
Member

skypexu commented Nov 9, 2023

Describe the bug (描述bug)
LRUCacheInterface lacks of virtual destructor, for a base class, virtual destructor is must-have.
otherwise, it will lead to memory or resource leaking in derived class.

A common guideline is that a destructor for a base class must be either public and virtual or protected and nonvirtual.

To Reproduce (复现方法)

Expected behavior (期望行为)

Versions (各种版本)
OS:
Compiler:
branch: master
commit id:

Additional context/screenshots (更多上下文/截图)

@skypexu skypexu added the bug Something isn't working label Nov 9, 2023
@skypexu skypexu closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants