Skip to content

Using cobra instead of cli #222

@ravisantoshgudimetla

Description

@ravisantoshgudimetla

Just wanted to know, if there is any specific reason for cli instead of cobra as we can reduce some of the code in generate.go using cobra. Something like

if context.IsSet("read-only") {
g.SetRootReadonly(context.Bool("read-only"))
}

could be set as :
cmd.Flags().BoolVar(&context.readonly, "read-only", context.readonly "make the container's rootfs read-only.")
where cmd here points to oci-runtime-tool generate

I may be missing an obvious point here as I am new to code base. Please, feel free to correct me in case I made some mistake.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions