Skip to content

fix(cli): add --overwrite to drive download and slides thumbnail#829

Merged
steipete merged 3 commits into
openclaw:mainfrom
WadydX:fix/drive-slides-overwrite-flag
Jun 18, 2026
Merged

fix(cli): add --overwrite to drive download and slides thumbnail#829
steipete merged 3 commits into
openclaw:mainfrom
WadydX:fix/drive-slides-overwrite-flag

Conversation

@WadydX

@WadydX WadydX commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • require explicit --overwrite before replacing local files
  • cover Drive downloads, Docs/Sheets/Slides exports, Docs tab exports, and Slides thumbnails
  • preserve stdout output behavior
  • add focused no-clobber and opt-in overwrite regression tests
  • regenerate command docs

Closes #827

Verification

  • focused command tests for every distinct writer path
  • make ci
  • live Google API proof for all six command paths: existing sentinel files were preserved without --overwrite; explicit overwrite produced valid PDF, XLSX, PPTX, and PNG artifacts
  • autoreview local changes: clean
  • autoreview complete PR branch: clean

Adds --overwrite flags to drive download and slides thumbnail --out,
matching the existing photos download behavior. Also covers drive
download --tab via the shared docs tab export path.

Closes openclaw#827
@WadydX WadydX force-pushed the fix/drive-slides-overwrite-flag branch from 9707b8e to 4c674ce Compare June 16, 2026 13:00
steipete and others added 2 commits June 18, 2026 00:26
@steipete steipete merged commit fa3fa16 into openclaw:main Jun 18, 2026
10 of 11 checks passed
@steipete

Copy link
Copy Markdown
Collaborator

Landed as fa3fa163.

Maintainer verification:

  • Focused regression tests: go test ./internal/cmd -run 'TestDownloadDriveFile|TestRunDocsTabExport|TestDocsExportCmd_TabRouting|TestSlidesThumbnail|TestExecute_DocsExport_JSON' -count=1
  • Full local gate: make ci
  • Autoreview: local diff and full branch review both returned no actionable findings.
  • Live Google API proof covered all six output paths: Drive download, Docs export, Docs tab export, Sheets export, Slides export, and Slides thumbnail. Each command refused an existing sentinel file without --overwrite, preserved its contents, then replaced it successfully with --overwrite and produced a valid artifact (PPTX, PDF, XLSX, or 1600x900 PNG as applicable).
  • GitHub checks: Linux, Windows, macOS, worker, image, and Socket checks all passed.

Thanks @WadydX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

drive download and slides thumbnail overwrite existing output files without opt-in

2 participants