feat(slides): add object-scoped text editing primitives

Author: clawsweeper[bot]

internal/cmd/slides_replace_text.go

@@ -183,15 +183,19 @@ func buildSlidesObjectReplaceTextRequests(pres *slides.Presentation, objectID, f
 		return nil, 0, usage("object-scoped replace-text currently supports shape text objects only")
 	}
 
-	matches := slidesTextMatches(text, find, matchCase)
+	matches := slidesTextMatches(text.content, find, matchCase)
 	if len(matches) == 0 {
 		return nil, 0, usage("no matching text found in object")
 	}
 
 	requests := make([]*slides.Request, 0, len(matches)*2)
 	for i := len(matches) - 1; i >= 0; i-- {
 		match := matches[i]
-		textRange, err := slidesFixedTextRange(match.start, match.end)
+		start, end, err := text.slidesRange(match.start, match.end)
+		if err != nil {
+			return nil, 0, err
+		}
+		textRange, err := slidesFixedTextRange(start, end)
 		if err != nil {
 			return nil, 0, err
 		}
@@ -205,7 +209,7 @@ func buildSlidesObjectReplaceTextRequests(pres *slides.Presentation, objectID, f
 			requests = append(requests, &slides.Request{
 				InsertText: &slides.InsertTextRequest{
 					ObjectId:       objectID,
-					InsertionIndex: match.start,
+					InsertionIndex: start,
 					Text:           replacement,
 				},
 			})
@@ -214,9 +218,37 @@ func buildSlidesObjectReplaceTextRequests(pres *slides.Presentation, objectID, f
 	return requests, len(matches), nil
 }
 
-func slidesShapeTextByObjectID(pres *slides.Presentation, objectID string) (string, bool, bool) {
+type slidesIndexedText struct {
+	content         string
+	codeUnitIndexes []int64
+}
+
+func (t slidesIndexedText) slidesRange(start, end int64) (int64, int64, error) {
+	if start < 0 || end <= start || end > int64(len(t.codeUnitIndexes)) {
+		return 0, 0, usage("matched text range is outside the object's Slides text indexes")
+	}
+	return t.codeUnitIndexes[start], t.codeUnitIndexes[end-1] + 1, nil
+}
+
+func (t *slidesIndexedText) appendTextRun(startIndex int64, content string) {
+	var b strings.Builder
+	b.WriteString(t.content)
+	b.WriteString(content)
+	t.content = b.String()
+
+	index := startIndex
+	for _, r := range content {
+		units := utf16CodeUnits(string(r))
+		for i := int64(0); i < units; i++ {
+			t.codeUnitIndexes = append(t.codeUnitIndexes, index+i)
+		}
+		index += units
+	}
+}
+
+func slidesShapeTextByObjectID(pres *slides.Presentation, objectID string) (slidesIndexedText, bool, bool) {
 	if pres == nil {
-		return "", false, false
+		return slidesIndexedText{}, false, false
 	}
 	for _, page := range pres.Slides {
 		if page == nil {
@@ -227,18 +259,18 @@ func slidesShapeTextByObjectID(pres *slides.Presentation, objectID string) (stri
 				continue
 			}
 			if el.Shape == nil || el.Shape.Text == nil {
-				return "", true, false
+				return slidesIndexedText{}, true, false
 			}
-			var b strings.Builder
+			var text slidesIndexedText
 			for _, textElement := range el.Shape.Text.TextElements {
 				if textElement != nil && textElement.TextRun != nil {
-					b.WriteString(textElement.TextRun.Content)
+					text.appendTextRun(textElement.StartIndex, textElement.TextRun.Content)
 				}
 			}
-			return b.String(), true, true
+			return text, true, true
 		}
 	}
-	return "", false, false
+	return slidesIndexedText{}, false, false
 }
 
 type slidesTextMatch struct {

internal/cmd/slides_replace_text_test.go

@@ -149,6 +149,42 @@ func TestSlidesReplaceText_ObjectScopedShapeText(t *testing.T) {
 	}
 }
 
+func TestSlidesReplaceText_ObjectScopedPreservesTextElementIndexes(t *testing.T) {
+	pres := &slides.Presentation{
+		Slides: []*slides.Page{{
+			PageElements: []*slides.PageElement{{
+				ObjectId: "shape_1",
+				Shape: &slides.Shape{Text: &slides.TextContent{
+					TextElements: []*slides.TextElement{
+						{StartIndex: 4, EndIndex: 10, TextRun: &slides.TextRun{Content: "prefix"}},
+						{StartIndex: 20, EndIndex: 23, TextRun: &slides.TextRun{Content: "old"}},
+					},
+				}},
+			}},
+		}},
+	}
+
+	requests, replaced, err := buildSlidesObjectReplaceTextRequests(pres, "shape_1", "old", "fresh", false)
+	if err != nil {
+		t.Fatalf("build requests: %v", err)
+	}
+	if replaced != 1 {
+		t.Fatalf("replaced = %d, want 1", replaced)
+	}
+	if len(requests) != 2 {
+		t.Fatalf("expected delete+insert request, got %d: %+v", len(requests), requests)
+	}
+	del := requests[0].DeleteText
+	if del == nil || del.TextRange == nil ||
+		*del.TextRange.StartIndex != 20 || *del.TextRange.EndIndex != 23 {
+		t.Fatalf("delete should use Slides text element indexes 20:23, got %#v", del)
+	}
+	ins := requests[1].InsertText
+	if ins == nil || ins.InsertionIndex != 20 || ins.Text != "fresh" {
+		t.Fatalf("insert should use Slides text element index 20, got %#v", ins)
+	}
+}
+
 func TestSlidesReplaceText_ObjectAndPageMutuallyExclusive(t *testing.T) {
 	flags := &RootFlags{Account: "a@b.com"}
 	ctx := withSlidesTestServiceFactory(