Skip to content

chore: authorize v0.78.1 release source - #2857

Merged
steipete merged 1 commit into
mainfrom
release/authorize-v0.78.1
Oct 15, 2026
Merged

steipete merged 1 commit into
mainfrom
release/authorize-v0.78.1

Conversation

@steipete

Copy link
Copy Markdown
Contributor

Authorize the immutable source identity for v0.78.1. The annotated SSH-signed tag is verified by GitHub and binds tag object 3c9f395ce03e738e47b6c5a684ba4b7ff58afa9d to source de312343dba72e14dfddee46189a8aaac48f3fbc. Exact-source CI, coordinator health, run/attach/events/logs and confirmed lease cleanup passed.

This record permits candidate production; it does not publish a release. The full release is explicitly authorized. No credentials or runtime configuration change.

Validation: exact-source CI https://github.com/openclaw/crabbox/actions/runs/38747275812, connector E2E https://github.com/openclaw/crabbox/actions/runs/38747275730, CodeQL https://github.com/openclaw/crabbox/actions/runs/38747275871, and coordinator deployment https://github.com/openclaw/crabbox/actions/runs/38747275709 passed. Coordinator smoke run_12d5fd52497442e8c3301b99b635db50 verified run, attach, events, logs, and released/complete cleanup.

@steipete
steipete requested a review from a team as a code owner October 15, 2026 14:21
@clawsweeper

clawsweeper Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T14:22:45.911250Z 3b5269d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Oct 15, 2026
@clawsweeper

clawsweeper Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge.

What this changes

This PR adds the protected source authorization record for v0.78.1.

Example: Produce a candidate for v0.78.1 from de31234.

  • Before: The source guard rejects the missing release record.
  • After: The record supplies the expected signed tag object and source commit for the existing release gates.

Review scores

Measure Result What it means
Overall readiness 🧂 unranked krab (1/6) The small record is internally consistent and follows the existing format; the required authority-boundary proof is incomplete.
Proof confidence 🧂 unranked krab (1/6) Real behavior proof is necessary before merge. See Before merge.
Patch quality 🦐 gold shrimp (3/6) Security review found an item that needs attention.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Release tooling needs a protected binding for the intended v0.78.1 source.
Reason: The record supplies an existing release prerequisite, and the host identifies this as maintainer-directed work.

Merge readiness

⛔ Blocked before merge - 3 items remain

Keep this PR open: main lacks the v0.78.1 authorization record, and its pinned identity matches GitHub’s verified signed tag; no introduced code defect was found.

Priority: P3
Reviewed head: 3b5269dc50741db24ae2bd43caa354d0feddc68b

Before merge

  • Add real behavior proof - Authority-chain proof required: the new ready record feeds the source guard and ultimately publication; supplied source CI and coordinator smoke do not demonstrate this record’s allowed path and nearest forbidden source or revoked authorization being rejected before the final effect. Existing signed-guard tests and simulated publisher tests support the design. A credential-free production-path trace is sufficient; redact credentials and non-public endpoints. After adding proof, update the PR body, then request a new review with @clawsweeper re-review. The PR author or someone with repository write access can request it.
  • Resolve security review attention item - The identity binding is correct, with no concrete bypass found, but final-effect authorization proof remains incomplete.
  • Resolve merge risk - The new ready record persists release eligibility; final-effect evidence must show that a mismatched source or revoked authorization cannot reach the release side effect.

Findings

None.

Tests

  • Missing end-to-end proof: Supply a redacted production-path trace for the pinned record showing allowed progress and rejection of mismatched or blocked authorization before the release effect.
Agent review details

How this fits together

Release tooling consumes protected JSON records and signed tag identities before candidate production and publication.

flowchart LR
  A[Signed version tag] --> C[Source identity guard]
  B[Protected release record] --> C
  C --> D[Candidate production]
  D --> E[Native verification]
  E --> F[Publication checks]
  B --> F
  F --> G[GitHub release]
Loading

Technical review

Best possible solution:

Retain this exact identity record and complete the existing protected release gates with scoped authorization-boundary evidence.

Do we have a high-confidence way to reproduce the issue?

This PR authorizes a release source rather than reporting a runtime bug.

Is this the best way to solve the issue?

The existing protected-record mechanism is the appropriate implementation, and the added values match the verified tag without changing release tooling.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against de312343dba7.

Merge-risk options

Maintainer options:

  1. Demonstrate the release authorization boundary (recommended)
    Provide a credential-free production-path trace showing acceptance of the pinned identity and rejection of a mismatched source or blocked record before the final release effect.

Testing

Proof path: in-process harness.

Security

Needs attention: The identity binding is correct, with no concrete bypass found, but final-effect authorization proof remains incomplete.

Evidence

What I checked:

  • Exact introduced change: The pinned diff adds only an eight-line schema-version-1 record; the reviewed main tree has no v0.78.1 record. (release/records/v0.78.1.json:1, 3b5269dc5074)
  • Verified immutable identity: GitHub reports tag object 3c9f395ce03e738e47b6c5a684ba4b7ff58afa9d as valid and verified, with tag v0.78.1 pointing to the record’s source commit. (release/records/v0.78.1.json:5, 3b5269dc5074)
  • Existing release contract: The source guard checks repository, version, tag object, source commit, publication status, allowed signature, and ancestry; publication repeats protected-source validation immediately before its release mutation. (scripts/publish-release.sh:316, de312343dba7)
  • Supporting validation and its scope: The linked source CI, connector E2E, and coordinator deployment runs completed successfully at the pinned source commit. These validate release contents, rather than consumption of this newly added authorization record. (de312343dba7)
  • Authorization test coverage: Existing tests exercise the real signed-source guard with accepted and mismatched identities and a disallowed signer; publisher tests assert blocked records cause no mutation using a simulated GitHub client. (scripts/release-workflow.test.js:651, de312343dba7)
  • Repository policy and routing: The full root AGENTS.md requires protected release records and the documented release sequence; no nested release AGENTS.md or maintainer-notes directory was present. CODEOWNERS assigns release records to openclaw-secops. (.github/CODEOWNERS:8, de312343dba7)

Likely related people:

  • Peter Steinberger: Raw commit 906f8d1 adds release/records/v0.78.0.json:7 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 906f8d11afa9; files: release/records/v0.78.0.json)
  • Vincent Koc: Raw commit 6ed607c adds release/records/v0.76.0.json:7 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: medium; commits: 6ed607c7591f; files: release/records/v0.76.0.json)

Labels

Label changes:

  • add P3: This is a routine release administration change with no demonstrated runtime regression.
  • add merge-risk: 🚨 security-boundary: The ready record is a persistent input to candidate and publication authorization, so successful source CI alone does not settle its final-effect boundary.
  • add rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🦐 gold shrimp.
  • add status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Label justifications:

  • P3: This is a routine release administration change with no demonstrated runtime regression.
  • merge-risk: 🚨 security-boundary: The ready record is a persistent input to candidate and publication authorization, so successful source CI alone does not settle its final-effect boundary.
  • rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🦐 gold shrimp.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Add final-effect proof for the pinned source and a mismatched source, and show that blocked or revoked authorization prevents the release effect.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 15, 2026, 10:34 AM ET / 14:34 UTC.

@steipete
steipete merged commit 5047d0e into main Oct 15, 2026
38 checks passed
@steipete
steipete deleted the release/authorize-v0.78.1 branch October 15, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant