-
Notifications
You must be signed in to change notification settings - Fork 231
refactor(review): git-native PR inspection (replaces prompt-hydrated patch text, per #68) #84
Copy link
Copy link
Open
Labels
P3Low-risk cleanup, docs, polish, ergonomics, or speculative feature.Low-risk cleanup, docs, polish, ergonomics, or speculative feature.clawsweeper:needs-maintainer-reviewClawSweeper marked this issue as needing maintainer review before automation.ClawSweeper marked this issue as needing maintainer review before automation.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.issue-rating: 🌊 off-meta tidepoolIssue quality rating does not apply to this item.Issue quality rating does not apply to this item.
Metadata
Metadata
Assignees
Labels
P3Low-risk cleanup, docs, polish, ergonomics, or speculative feature.Low-risk cleanup, docs, polish, ergonomics, or speculative feature.clawsweeper:needs-maintainer-reviewClawSweeper marked this issue as needing maintainer review before automation.ClawSweeper marked this issue as needing maintainer review before automation.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.issue-rating: 🌊 off-meta tidepoolIssue quality rating does not apply to this item.Issue quality rating does not apply to this item.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Following #68's close — confirming the replacement design before opening code so it matches the intended direction.
Plan:
main(preserve the read-only invariant — do not materialize the PR as the working tree).fetchSourcePullRequestHeadprimitive (src/repair/source-pr-checkout.ts) to fetchrefs/pull/<n>/headinto a read-onlyrefs/remotes/clawsweeper/...ref — no new parallel helper.prompts/review-item.mdto inspect viagit diff origin/main...<ref>andgit show <ref>:path.compactPullFilesForPromptto file metadata only, dropping patch bodies. Verified.patchis consumed only by the prompt builder; repair/automerge gates run on the decision JSON + live git, so nothing downstream breaks.Open question I want to get right: the
maincheckout is--filter=blob:none, so I'd pre-warm the PR diff blobs deterministically under ClawSweeper's control rather than let Codex trigger lazy promisor fetches inside the sandbox.Net effect: deletes the truncation layer entirely, simpler core bot. @steipete does this match the direction from #68? I'll scope it as
refactor(review):off freshmain.