Do not include invisible market in Market.all

Author: lgn21st

app/models/market.rb

@@ -11,8 +11,15 @@
 class Market < ActiveYamlBase
   include Enumerizeable
 
+  field :visible, default: true
+
   attr :name, :target_unit, :price_unit
 
+  self.singleton_class.send :alias_method, :orig_all, :all
+  def self.all
+    orig_all.select &:visible
+  end
+
   # TODO: our market id is the opposite of conventional market name.
   # e.g. our 'btccny' market should use 'btccny' as id, and its name should
   # be 'BTC/CNY'

config/markets.yml.example

@@ -2,3 +2,4 @@
   code: 3
   bid: {fee: 0, currency: cny, fixed: 2}
   ask: {fee: 0, currency: btc, fixed: 4}
+  #visible: false     # default to true

spec/fixtures/currencies.yml

@@ -9,3 +9,7 @@
   rpc: http://bitcoinrpc:[email protected]:18332
   blockchain: http://testnet.btclook.com/txn/#{txid}
   address_url: https://blockchain.info/address/#{address}
+- id: 4
+  key: protoshare
+  code: pts
+  coin: true

spec/fixtures/markets.yml

@@ -2,3 +2,8 @@
   code: 3
   bid: {fee: 0, currency: cny, fixed: 2}
   ask: {fee: 0, currency: btc, fixed: 4}
+- id: ptsbtc
+  code: 6
+  bid: {fee: 0, currency: btc, fixed: 4}
+  ask: {fee: 0, currency: pts, fixed: 4}
+  visible: false

spec/models/market_spec.rb

@@ -2,16 +2,23 @@
 
 describe Market do
 
-  subject { Market.find('btccny') }
-
-  its(:id)          { should == 'btccny' }
-  its(:name)        { should == 'BTC/CNY' }
-  its(:target_unit) { should == 'btc' }
-  its(:price_unit)  { should == 'cny' }
-
   it "should raise argument error on invalid market id" do
     expect { Market.new(id: 'dogecny') }.to raise_error(ArgumentError)
     expect { Market.new(id: 'dogcny') }.not_to raise_error
   end
 
+  context 'visible market' do
+    it { expect(Market.orig_all.count).to eq(2) }
+    it { expect(Market.all.count).to eq(1) }
+  end
+
+  context 'market attributes' do
+    subject { Market.find('btccny') }
+
+    its(:id)          { should == 'btccny' }
+    its(:name)        { should == 'BTC/CNY' }
+    its(:target_unit) { should == 'btc' }
+    its(:price_unit)  { should == 'cny' }
+    its(:visible)     { should be_true }
+  end
 end