Allow unknown string format properties (#65)

Author: Adam Gray

openapi_python_client/openapi_parser/properties.py

@@ -364,16 +364,14 @@ def _string_based_property(
 ) -> Union[StringProperty, DateProperty, DateTimeProperty, FileProperty]:
     """ Construct a Property from the type "string" """
     string_format = data.get("format")
-    if string_format is None:
-        return StringProperty(name=name, default=data.get("default"), required=required, pattern=data.get("pattern"))
     if string_format == "date-time":
         return DateTimeProperty(name=name, required=required, default=data.get("default"))
     elif string_format == "date":
         return DateProperty(name=name, required=required, default=data.get("default"))
     elif string_format == "binary":
         return FileProperty(name=name, required=required, default=data.get("default"))
     else:
-        raise ParseError(data=data, message=f'Unsupported string format:{data["format"]}')
+        return StringProperty(name=name, default=data.get("default"), required=required, pattern=data.get("pattern"))
 
 
 def property_from_dict(name: str, required: bool, data: Dict[str, Any]) -> Property:

tests/test_openapi_parser/test_properties.py

@@ -640,8 +640,23 @@ def test__string_based_property_unsupported_format(self, mocker):
             "type": "string",
             "format": mocker.MagicMock(),
         }
+        StringProperty = mocker.patch(f"{MODULE_NAME}.StringProperty")
 
         from openapi_python_client.openapi_parser.properties import _string_based_property
 
-        with pytest.raises(ValueError):
-            _string_based_property(name=name, required=required, data=data)
+        p = _string_based_property(name=name, required=required, data=data)
+
+        StringProperty.assert_called_once_with(name=name, required=required, pattern=None, default=None)
+        assert p == StringProperty.return_value
+
+        # Test optional values
+        StringProperty.reset_mock()
+        data["default"] = mocker.MagicMock()
+        data["pattern"] = mocker.MagicMock()
+
+        _string_based_property(
+            name=name, required=required, data=data,
+        )
+        StringProperty.assert_called_once_with(
+            name=name, required=required, pattern=data["pattern"], default=data["default"]
+        )