SerialIOTest: Clang-Tidy Fixes (#1599)

ax3l · web-flow · commit 045e416ab74b · 2024-02-27T13:08:37.000-08:00
Small updates seen by Clang-Tidy.
diff --git a/test/SerialIOTest.cpp b/test/SerialIOTest.cpp
@@ -5469,6 +5469,7 @@ void adios2_group_table(
     write.close();
 
     Series read("../samples/group_table.bp", Access::READ_LINEAR, jsonRead);
+    // NOLINTNEXTLINE(performance-for-range-copy)
     for (auto iteration : read.readIterations())
     {
         switch (iteration.iterationIndex)
@@ -6515,7 +6516,7 @@ TEST_CASE("deferred_parsing", "[serial]")
 }
 
 #if openPMD_HAS_ADIOS_2_9
-void chaotic_stream(std::string filename, bool variableBased)
+void chaotic_stream(std::string const &filename, bool variableBased)
 {
     /*
      * We will write iterations in the following order.

Original file line number	Diff line number	Diff line change
`@@ -5469,6 +5469,7 @@ void adios2_group_table(`
`5469`	`5469`	`write.close();`
`5470`	`5470`
`5471`	`5471`	`Series read("../samples/group_table.bp", Access::READ_LINEAR, jsonRead);`
	`5472`	`+ // NOLINTNEXTLINE(performance-for-range-copy)`
`5472`	`5473`	`for (auto iteration : read.readIterations())`
`5473`	`5474`	`{`
`5474`	`5475`	`switch (iteration.iterationIndex)`
`@@ -6515,7 +6516,7 @@ TEST_CASE("deferred_parsing", "[serial]")`
`6515`	`6516`	`}`
`6516`	`6517`
`6517`	`6518`	`#if openPMD_HAS_ADIOS_2_9`
`6518`		`-void chaotic_stream(std::string filename, bool variableBased)`
	`6519`	`+void chaotic_stream(std::string const &filename, bool variableBased)`
`6519`	`6520`	`{`
`6520`	`6521`	`/*`
`6521`	`6522`	`* We will write iterations in the following order.`