🔧 do not allow useChrome to set falseyexecutablePath #2360

smashah · smashah · commit 2bd9ec170f76 · 2021-12-18T18:30:02.000+03:00
diff --git a/src/controllers/browser.ts b/src/controllers/browser.ts
@@ -251,6 +251,7 @@ async function initBrowser(sessionId?: string, config:any={}) {
     if(!_savedPath) {
       const chromeLauncher = await import('chrome-launcher')
       config.executablePath = chromeLauncher.Launcher.getInstallations()[0];
+      if(!config.executablePath) delete config.executablePath;
       await storage.setItem('executablePath',config.executablePath)
     } else config.executablePath = _savedPath;
   }

Original file line number	Diff line number	Diff line change
`@@ -251,6 +251,7 @@ async function initBrowser(sessionId?: string, config:any={}) {`
`251`	`251`	`if(!_savedPath) {`
`252`	`252`	`const chromeLauncher = await import('chrome-launcher')`
`253`	`253`	`config.executablePath = chromeLauncher.Launcher.getInstallations()[0];`
	`254`	`+ if(!config.executablePath) delete config.executablePath;`
`254`	`255`	`await storage.setItem('executablePath',config.executablePath)`
`255`	`256`	`} else config.executablePath = _savedPath;`
`256`	`257`	`}`