You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
i would like to have some additional labels for the http metrics http_server_duration_average_us_total and http_server_client_average_us_total
these include: http_verb, status codehttp_route
for route, i think we can try to infer the route template to not pollute with to many labels
i.e if we see /api/v1/customers/1 + /api/v1/customers/2 + /api/v1/customers/3 we can infer the route to be /api/v1/customers/$id or something like that, we can think of a logic to try to infer that
Describe the solution you'd like
change the ebpf probes to extract method, status code and route from the http request, and add it as labels to the existing metrics
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
Awesome @NimrodAvni78 ! It will be a good capability to add!
I’d really love to see a design that would preserve the current system’s O(1) cost of handling each incoming event, because this property has been extremely useful in providing predictable performance for users.
My intuition is this is achievable, e.g., decide to handle at most N path components (say N=5) and use a hash table to keep collected metrics and which templates have been inferred. If inference logic can work “on-line” (i.e., logic can find templates as samples are coming in one at a time, without batch-processing) and is O(1) for that inference, that means inference and collection are both O(1).
The framework offers hash tables and infra to output metrics for items stored in those hash tables (which all current metrics use).
For transparency I’m unavailable to have a discussion about this in the next few weeks (I’m on leave). Happy to discuss in September if you haven’t finished this already :)
Is your feature request related to a problem? Please describe.
i would like to have some additional labels for the http metrics
http_server_duration_average_us_total
andhttp_server_client_average_us_total
these include:
http_verb
,status code
http_route
for route, i think we can try to infer the
route template
to not pollute with to many labelsi.e if we see
/api/v1/customers/1
+/api/v1/customers/2
+/api/v1/customers/3
we can infer the route to be/api/v1/customers/$id
or something like that, we can think of a logic to try to infer thatDescribe the solution you'd like
change the ebpf probes to extract method, status code and route from the http request, and add it as labels to the existing metrics
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: