Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ActivitySource.Tags in ZipkinExporter #5936

Open
CodeBlanch opened this issue Oct 29, 2024 · 0 comments
Open

Support ActivitySource.Tags in ZipkinExporter #5936

CodeBlanch opened this issue Oct 29, 2024 · 0 comments
Labels
help wanted Good for taking. Extra help will be provided by maintainers pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package traces Tracing signal related
Milestone
Future

Comments

@CodeBlanch
Copy link
Member

Relates to #5701

ActivitySource.Tags was added in .NET 9. These tags are not currently exported when using ZipkinExporter.

The spec seems to say these attributes should be sent with span tags. But it doesn't specify how to handle collisions.

This issue is about doing something in ZipkinExporter to support instrumentation scope tags.

Questions...

  • What have other languages/SIGs done?
  • Should we work through the spec to clarify what to do?
@CodeBlanch CodeBlanch added help wanted Good for taking. Extra help will be provided by maintainers traces Tracing signal related pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package labels Oct 29, 2024
@CodeBlanch CodeBlanch added this to the Future milestone Oct 29, 2024
@CodeBlanch CodeBlanch mentioned this issue Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Good for taking. Extra help will be provided by maintainers pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package traces Tracing signal related
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@CodeBlanch